http: Increase listen backlog to 40 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
http-backlog
branch
2 times, most recently
from
24d5620
to
5d9d183
Compare
vjuranek
reviewed
Mar 21, 2022
bennyz
previously approved these changes
Mar 21, 2022
Both TCP and unix socket based servers inherited the listen backlog from
python socketserver.TCPServer. The default value (5) was never a
problem, but new automated tests using 16 concurrent connections started
to fail randomly recently with:
ERR: Traceback (most recent call last):
...
File "ovirt_imageio/_internal/backends/http.py", line 392, in _create_unix_connection
con.connect()
File "ovirt_imageio/_internal/backends/http.py", line 627, in connect
self.sock.connect(self.path)
BlockingIOError: [Errno 11] Resource temporarily unavailable
Increase the backlog to 40. We recommend to do up to 10 image transfers
per host. Doing more will work, but if someone will try to start 60
connections at the same time they will likely experience the same error,
which is good sign that they are overloading the system.
Bug-Url: https://bugzilla.redhat.com/2066113
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Test 10 concurrent downloads, each creating 4 connections, reproducing the bug with the default backlog size. Bug-Url: https://bugzilla.redhat.com/2066113 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
vjuranek
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both TCP and unix socket based servers inherited the listen backlog from
python socketserver.TCPServer. The default value (5) was never a
problem, but new automated tests using 16 concurrent connections started
to fail randomly recently with:
Increase the backlog to 40. We recommend to do up to 10 image transfers
per host. Doing more will work, but if someone will try to start 60
connections at the same time they will likely experience the same error,
which is good sign that they are overloading the system.
Bug-Url: https://bugzilla.redhat.com/2066113
Signed-off-by: Nir Soffer nsoffer@redhat.com