Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt-log-collector: Clarified the --log-size option meaning #17

Merged
merged 1 commit into from
May 31, 2022

Conversation

lveyde
Copy link
Member

@lveyde lveyde commented May 31, 2022

Updated the help for the --log-size option, to avoid confusing the
limit on the individual log (per sos plugin), with the limit on
the total size of the log produced for the host, which is not
implemented in sos.

RHBZ#2081676 ( https://bugzilla.redhat.com/2081676 )

Signed-off-by: Lev Veyde lveyde@redhat.com

Fixes issue # (delete if not relevant)

Changes introduced with this PR

  • Clarified the help for the --log-size option

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y]

Updated the help for the --log-size option, to avoid confusing the
limit on the individual log (per sos plugin), with the limit on
the total size of the log produced for the host, which is not
implemented in sos.

RHBZ#2081676 ( https://bugzilla.redhat.com/2081676 )

Signed-off-by: Lev Veyde <lveyde@redhat.com>
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lveyde lveyde merged commit de2c993 into oVirt:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants