Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design for listing VMs pinned to a host. #1169

Merged
merged 1 commit into from Sep 10, 2017

Conversation

akrejcir
Copy link
Contributor

Changes proposed in this pull request:
A design page for showing VMs pinned to a host.

We should discuss:

  • what is a good way to expose the new query through REST API
  • what is a good way to show the pinned VMs in the webadmin

I confirm that this pull request was submitted according to the contribution guidelines: @akrejcir

This pull request needs review by: @jhernand @pcbailey

@akrejcir
Copy link
Contributor Author

@vojtechszocs @sjd78

@vojtechszocs
Copy link
Contributor

For WebAdmin, either showing a separate list of pinned VMs (right below the list of running VMs) within "Host / Virtual Machines", or having a separate "Host / Pinned VMs" detail tab, sounds reasonable. I'd personally prefer the first of these two, since the available space is much bigger now (no more "main tab" stuff showing above).

@pcbailey
Copy link
Contributor

I agree 100% with @vojtechszocs. I think it best to keep the VM-related information together in the same sub tab, but as you pointed out, mixing the pinned VMs and those running on the host could get confusing. A separate list would avoid that problem while keeping the information in the Virtual Machines sub tab.

@akrejcir
Copy link
Contributor Author

akrejcir commented Sep 4, 2017

I have added an image of how the two lists would look on one page.

@doron-fediuck
Copy link
Contributor

@vojtechszocs @pcbailey any objections to merge?

@pcbailey
Copy link
Contributor

pcbailey commented Sep 6, 2017

No objections from me.

@doron-fediuck doron-fediuck merged commit daaf3ff into oVirt:master Sep 10, 2017
@akrejcir akrejcir deleted the list-vms-pinned-to-host branch September 11, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants