Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update information about special volume on block storage #1994

Merged
merged 1 commit into from
May 26, 2019
Merged

Update information about special volume on block storage #1994

merged 1 commit into from
May 26, 2019

Conversation

nirs
Copy link
Member

@nirs nirs commented May 17, 2019

  • added xleases
  • fix description of metadata
  • fix for description of leases
  • fix description of ids

@rollandf, @vjuranek please review.

- added xleases
- fix description of metadata
- fix for description of leases
- fix description of ids
@nirs nirs requested a review from rollandf May 17, 2019 15:21
Copy link
Member

@vjuranek vjuranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd include removing of mailbox link as part of this change.

* We allocate 5 "special" volumes:
1. metadata - contains the domain\\pool and volume metadata
* We allocate 6 "special" volumes:
1. metadata - contains volume metadata
2. inbox and outbox - used for the [mailbox](mailbox)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when in it, could you please remove link to mailbox? This page doesn't seems to exist.

@nirs
Copy link
Member Author

nirs commented May 26, 2019

Thanks for reviewing! Lets first get the wrong data fixed. We can check why the mailbox link is broken later.

@nirs nirs merged commit 41c535f into master May 26, 2019
@sandrobonazzola sandrobonazzola deleted the docs branch July 31, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants