ci: add pylint job

.github/workflows/pylint.yml

@@ -0,0 +1,26 @@
+name: Pylint
+
+on: [push, pull_request]
+
+jobs:
+  pylint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.8", "3.9", "3.10"]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        sudo apt install libcurl4-gnutls-dev librtmp-dev
+        python -m pip install --upgrade pip
+        pip install pylint
+        pip install ovirt-imageio
+        pip install ovirt-engine-sdk-python
+        pip install pyyaml
+    - name: Analysing the code with pylint
+      run: pylint $(git ls-files '*.py')

backup/backup.py

@@ -18,12 +18,12 @@
 import ovirtsdk4 as sdk
 import ovirtsdk4.types as types
 
-import imagetransfer
+from . import imagetransfer
 
 log = logging.getLogger("backup")
 
 
-class Timeout:
+class Timeout(Exception):
     """
     Raised when starting or stopping a backup times out.
     """
@@ -238,8 +238,8 @@ def _get_backup(backup_service, backup_id):
     """
     try:
         backup = backup_service.get()
-    except sdk.NotFoundError:
-        raise RuntimeError(f"Backup {backup_id} does not exist")
+    except sdk.NotFoundError as e:
+        raise RuntimeError(f"Backup {backup_id} does not exist") from e
 
     if backup.phase == types.BackupPhase.FAILED:
         raise RuntimeError(f"Backup {backup_id} has failed")

backup/imagetransfer.py

@@ -182,9 +182,9 @@ def create_transfer(
     while True:
         try:
             transfer = transfer_service.get()
-        except sdk.NotFoundError:
+        except sdk.NotFoundError as e:
             # The system has removed the disk and the transfer.
-            raise RuntimeError(f"Transfer {transfer.id} was removed")
+            raise RuntimeError(f"Transfer {transfer.id} was removed") from e
 
         if transfer.phase == types.ImageTransferPhase.FINISHED_FAILURE:
             # The system will remove the disk and the transfer soon.
@@ -281,7 +281,7 @@ def finalize_transfer(connection, transfer, disk, timeout=300):
         time.sleep(1)
         try:
             transfer = transfer_service.get()
-        except sdk.NotFoundError:
+        except sdk.NotFoundError as e:
             # Old engine (< 4.4.7): since the transfer was already deleted from
             # the database, we can assume that the disk status is already
             # updated, so we can check it only once.
@@ -290,16 +290,16 @@ def finalize_transfer(connection, transfer, disk, timeout=300):
                                 .disk_service(disk.id))
             try:
                 disk = disk_service.get()
-            except sdk.NotFoundError:
+            except sdk.NotFoundError as e:
                 # Disk verification failed and the system removed the disk.
                 raise RuntimeError(
-                    f"Transfer {transfer.id} failed: disk {disk.id} was removed")
+                    f"Transfer {transfer.id} failed: disk {disk.id} was removed") from e
 
             if disk.status == types.DiskStatus.OK:
                 break
 
             raise RuntimeError(
-                f"Transfer {transfer.id} failed: disk {disk.id} status {disk.status}")
+                f"Transfer {transfer.id} failed: disk {disk.id} status {disk.status}") from e
 
         log.debug("Transfer %r in phase %r", transfer.id, transfer.phase)
 

backup/test.py

@@ -1,20 +1,17 @@
-import argparse
 import logging
 import os
 import shutil
 import subprocess
 import threading
 import time
 import uuid
-import yaml
-
 from collections import Counter
 
+import yaml
 import ovirtsdk4 as sdk
 import ovirtsdk4.types as types
 
-import backup
-import imagetransfer
+from . import backup
 
 log = logging.getLogger("test")
 

delete-snapshot-chain/test.py

@@ -2,10 +2,9 @@
 import threading
 import time
 import uuid
-import yaml
-
 from collections import Counter
 
+import yaml
 import ovirtsdk4 as sdk
 import ovirtsdk4.types as types
 
@@ -68,7 +67,7 @@ def run(self):
 
     def setup(self):
         self.vm = None
-        self.snapshot = None
+        self.snapshots = []
         self.check_data_center()
         self.create_vm()
         self.start_vm()

delete-snapshot/test.py

@@ -1,13 +1,11 @@
-import argparse
 import logging
 import subprocess
 import threading
 import time
 import uuid
-import yaml
-
 from collections import Counter
 
+import yaml
 import ovirtsdk4 as sdk
 import ovirtsdk4.types as types