Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show file system chart when there is >0 file systems #1056

Merged
merged 1 commit into from Jul 10, 2019
Merged

Only show file system chart when there is >0 file systems #1056

merged 1 commit into from Jul 10, 2019

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Jul 3, 2019

Fixes: #1055

There is a permutation where the standard QEMU guest agent
will not report actual per file system data. In this case, the
VM's disks.usage statistic is an empty array. This case is
now tested, and if the usage array is empty, the unallocated vs
provisioned donut chart is displayed (as if the guest agent is
not installed).

Showing the same VM used to report #1055:
screenshot-localhost-3000-2019 07 03-15-16-49

@sjd78
Only show file system chart when there is >1 file system
3bc479b 
Fixes: oVirt#1055

There is a permutation where the standard QEMU guest agent
will not report actual per file system data.  In this case, the
VM's `disks.usage` statistic is an empty array.  This case is
now tested, and if the usage array is empty, the unallocated vs
provisioned donut chart is displayed (as if the guest agent is
not installed).
@sjd78 sjd78 changed the title Only show file system chart when there is >1 file system Only show file system chart when there is >0 file systems Jul 3, 2019
bond95
bond95 approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@bond95 bond95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thaorell
thaorell approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@thaorell thaorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 added Flag: Needs QE needs testing by QE team before merging PR and closing issue Status: ON_QA status ON_QA (currently being tested) labels Jul 8, 2019
@isaranova
Copy link

ci build please

1 similar comment
@bond95
Copy link
Contributor

bond95 commented Jul 10, 2019

ci build please

@isaranova
Copy link

LGTM

@bond95 bond95 merged commit 4f249b8 into oVirt:master Jul 10, 2019
@lwrigh
Copy link

lwrigh commented Jul 11, 2019

LGTM

@sjd78 sjd78 deleted the qemu-guest-agent-disks branch July 12, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bond95 bond95 bond95 approved these changes

@thaorell thaorell thaorell approved these changes

@sgratch sgratch Awaiting requested review from sgratch

@lwrigh lwrigh Awaiting requested review from lwrigh

Assignees
No one assigned
Labels
Flag: Needs QE needs testing by QE team before merging PR and closing issue Status: ON_QA status ON_QA (currently being tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMs with qemu guest agent don't render utilization disk chart
5 participants
@sjd78 @isaranova @bond95 @lwrigh @thaorell