iscsi: Keep existing session on "session exists" (backport for 4.5.0) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If logging in to a node fails with "session exists" (error 15):
iscsiadm: initiator reported error (15 - session exists)
We use to remove the node, which disconnects the node and remove it.
This is not new behavior, but it seems that in 4.4 this cleanup was not
effective in the case of logging in to the same connection more than
once, and now it reliably disconnect the first node and leave the host
without any nodes, which makes it non operational.
Change iscsiadm to raise new IscsiSessionExists error, and keep the
existing session when handling this error.
With this change, if you try to connect to the same target more than
once, the host should end with one connected target.
Bug-Url: https://bugzilla.redhat.com/2083271
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
backport/4.5.0/iscsi-session-exists
branch
from
3a3dc51
to
2d060a5
Compare
nirs
changed the title
|
Too late for 4.5.0 now, the fix will be available in 4.5.1 via #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If logging in to a node fails with "session exists" (error 15):
We use to remove the node, which disconnects the node and remove it.
This is not new behavior, but it seems that in 4.4 this cleanup was not
effective in the case of logging in to the same connection more than
once, and now it reliably disconnect the first node and leave the host
without any nodes, which makes it non operational.
Change iscsiadm to raise new IscsiSessionExists error, and keep the
existing session when handling this error.
With this change, if you try to connect to the same target more than
once, the host should end with one connected target.
NOTE: This is a backport for testing the patch with QE automated tests.
Bug-Url: https://bugzilla.redhat.com/2083271
Signed-off-by: Nir Soffer nsoffer@redhat.com