virt: Fix long VNC passwords in vm_libvirt_hook.py #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of libvirt accept VNC passwords of the maximum length 8, because QEMU uses only the first 8 characters anyway. We have already fixed the password length in Engine but if we migrate VMs created by older Engines they may fail to start on the destination due to the long VNC password. Let’s make those VMs migratable to newer hosts by fixing the password in the libvirt hook. We can simply remove the extra unused characters from the password to make libvirt happy. Bug-Url: https://bugzilla.redhat.com/2090156
mz-pdm
added
bug
nirs
approved these changes
Jun 1, 2022
We don't -- we cannot fix all old hosts running the VMs with incompatible passwords without being able to migrate the VMs to newer hosts. |
|
We can't lookup the password somewhere and reset it on upgrade? |
ahadas
approved these changes
Jun 2, 2022
|
/ost |
Responded in BZ (briefly, the solution in this patch is much safer and easier). |
nyoxi
approved these changes
Jun 2, 2022
liranr23
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of libvirt accept VNC passwords of the maximum length 8,
because QEMU uses only the first 8 characters anyway. We have already
fixed the password length in Engine but if we migrate VMs created by
older Engines they may fail to start on the destination due to the
long VNC password.
Let’s make those VMs migratable to newer hosts by fixing the password
in the libvirt hook. We can simply remove the extra unused characters
from the password to make libvirt happy.
Bug-Url: https://bugzilla.redhat.com/2090156