blockVolume: check parent tag and meta match #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
added
the
verified
nirs
requested changes
Jul 20, 2022
aesteve-rh
force-pushed
the
aesteve/lvm-cache-check-parent-tag
branch
from
0d02269
to
5b2ee4a
Compare
|
/ost |
nirs
reviewed
Jul 21, 2022
aesteve-rh
force-pushed
the
aesteve/lvm-cache-check-parent-tag
branch
3 times, most recently
from
189ffd9
to
5d91a73
Compare
nirs
previously approved these changes
Jul 25, 2022
aesteve-rh
force-pushed
the
aesteve/lvm-cache-check-parent-tag
branch
from
5d91a73
to
76a8111
Compare
bennyz
approved these changes
Jul 25, 2022
nirs
approved these changes
Jul 25, 2022
blockVolume getParent method uses the volume tag PU_<id> to obtain the parent. However, this tag could be outdated. For example, when the host syncs a volume chain after removing a volume, it only updates the metadata. Afterwards, the SPM will update the volume tag once the volume is deleted. To ensure we do not return outdated parent UUID, we need to ensure that the parent UUID obtained from the parent tag, and the UUID in the volume metadata match. If they do not, we try to reload the volume tag first. If they still do not match after that, log a warning and use the metadata parent. Bug-Url: https://bugzilla.redhat.com/2103582 Signed-off-by: Albert Esteve <aesteve@redhat.com>
nirs
force-pushed
the
aesteve/lvm-cache-check-parent-tag
branch
from
76a8111
to
aeeaa81
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockVolume getParent method uses the volume tag
PU_ to obtain the parent. However, this tag
could be outdated. For example, when the host
syncs a volume chain after removing a volume,
it only updates the metadata. Afterwards,
the SPM will update the volume tag once the
volume is deleted.
To ensure we do not return outdated parent UUID,
we need to ensure that the parent UUID obtained
from the parent tag, and the UUID in the volume
metadata match, and log a warning and update
the volume otherwise.
Tested with ovirt-stress: https://gitlab.com/nirs/ovirt-stress/-/merge_requests/14
It consistently triggered the bug in each run. After upgrading with this
branch patch, it passed each iteration (tried 10 iterations).
In the logs it can be seen:
Bug-Url: https://bugzilla.redhat.com/2103582
Signed-off-by: Albert Esteve aesteve@redhat.com