Numa migration #99
Merged
Numa migration #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoxi
force-pushed
the
numa-migration
branch
2 times, most recently
from
dc521c3
to
05ad7f6
Compare
mz-pdm
reviewed
Mar 18, 2022
updated |
|
verified |
Please use "verified" label to mark Vdsm PRs as verified. |
I am not allowed to modify label. In fact, I am not allowed to modify anything besides PR title. |
mz-pdm
approved these changes
Mar 18, 2022
Oops, that's not very good. And nobody from Vdsm maintainers is allowed to view permission settings to check them. Let's ask on the mailing list then. |
mz-pdm
added
the
verified
When migrating a NUMA VM to another host the pinning to physical NUMA may need to be updated. This may be because the corresponding pNUMA used on source is in use by other VMs on destination, or because the hardware does not exactly match between hosts. Change-Id: I26fcaed59ef22035329ec06217562b12ad186b75 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
The original implementation was pre-creating XML elements early on the VM.migrate call. The rationale behind it being to validate the passed parameter and avoid as many errors as possible later in the migration thread. This however makes it useful only for CPU policies that do not have manual pinning (otherwise it would lead to duplicate elements in final XML). To make it possible to reconfigure also manual CPU pinning during migration the code was split. The parameter verification is still done early but the XML is constructed later in the source thread as needed. Change-Id: Ic4b50d59ea7bbb8e9b814852044934cbca048550 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/ost |
1 similar comment
|
/ost |
liranr23
reviewed
Mar 21, 2022
liranr23
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary code and API changes to allow migration of NUMA VMs. It has to be possible to adapt the NUMA pinning during migration because CPUs on destination host may be used differently or destination host may have different hardware. Similarly it is necessary to allow modification to manual CPU pinning to limit virtual NUMA cells to corresponding physical NUMA cells.