Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clutter.Container.add_actor removed in GNOME 46 #259

Closed
kra-mo opened this issue Feb 15, 2024 · 1 comment · Fixed by #264
Closed

Clutter.Container.add_actor removed in GNOME 46 #259

kra-mo opened this issue Feb 15, 2024 · 1 comment · Fixed by #264

Comments

@kra-mo
Copy link

kra-mo commented Feb 15, 2024

Clutter.Actor.add_child should be used instead.

A naïve find and replace of add_actor to add_child in extension.js seems to do the job but I'm not experienced enough to say for sure.

@kra-mo
Copy link
Author

kra-mo commented Feb 15, 2024

The method has already been deprecated for a while so this is overdue anyway.

carlwgeorge added a commit to carlwgeorge/shell that referenced this issue Mar 11, 2024
It looks like .add() and .add_actor() were removed in GNOME 46.
Replacing these with .add_child() seems to work.  With these changes I'm
able to successfully install and use the extension on GNOME 46 RC.

oae/gnome-shell-pano#259
https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/350cd296fa90adb3d18f9b375b5531077cff825a
@underdoeg underdoeg mentioned this issue Mar 24, 2024
8 tasks
jackpot51 pushed a commit to pop-os/shell that referenced this issue Mar 25, 2024
It looks like .add() and .add_actor() were removed in GNOME 46.
Replacing these with .add_child() seems to work.  With these changes I'm
able to successfully install and use the extension on GNOME 46 RC.

oae/gnome-shell-pano#259
https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/350cd296fa90adb3d18f9b375b5531077cff825a
@oae oae closed this as completed in #264 Mar 26, 2024
birneee pushed a commit to birneee/shell that referenced this issue May 15, 2024
It looks like .add() and .add_actor() were removed in GNOME 46.
Replacing these with .add_child() seems to work.  With these changes I'm
able to successfully install and use the extension on GNOME 46 RC.

oae/gnome-shell-pano#259
https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/350cd296fa90adb3d18f9b375b5531077cff825a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant