Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the request library #2045

Open
3 tasks
brecke opened this issue Mar 4, 2020 · 0 comments
Open
3 tasks

Replace the request library #2045

brecke opened this issue Mar 4, 2020 · 0 comments
Assignees
Milestone

Comments

@brecke
Copy link
Member

brecke commented Mar 4, 2020

The request library is deprecated and holds several security vulnerabilities. Alternatives to be chosen from this list

EDIT: Here's another one: https://github.com/nodejs/undici

EDIT: We could just use node-fetch, but it lacks callbacks

TODO:

  • Replace in oae-rest
  • Replace in Hilary
  • Test failing: verify folder ids can be specified when creating content

EDIT:

This is a promise-only library, so... we'll need to implement #2092 first. Oh well.

@brecke brecke self-assigned this Mar 4, 2020
@brecke brecke added this to the 16.0.3 milestone Apr 5, 2020
@brecke brecke modified the milestones: 16.0.3, 17.0.0 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant