Tenant landing pages #1088
Closed
Tenant landing pages #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a dedicated endpoint for tenant landing pages at /api/tenant/landing-page. An array of landing page blocks will be returned
| @@ -70,6 +70,26 @@ var Context = module.exports.Context = function(tenant, user, authenticationStra | |||
| }; | |||
|
|
|||
| /** | |||
| * The resolved locale for a user. | |||
There was a problem hiding this comment.
Can you remove the dot here per the other blocks?
|
Finished review. Back to @simong for follow-up |
* 12 blocks rather than 6 * Configured 5 default blocks so the default landing page looks prettier * `/api/tenant/landingPage` rather than `/api/tenant/landing-page` * Alphabetised landing page block rest model * Added a test utility to clear a tenant’s landing page
|
Followed-up with things. Back to @nicolaasmatthijs |
|
Left some final comments. Back to @simong for follow-up |
|
Pushed more things |
* Added a search block * Cleaned up config section for landing page * Resolving image/video URLs in hashed paths
simong
force-pushed
the
landing-pages
branch
from
40e9ed4
to
b0aaec3
Compare
|
Looks good. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the UI to retrieve configurable information to put on the tenant landing pages