Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdffulltext #1103

Merged
merged 10 commits into from
Jan 8, 2015
Merged

Pdffulltext #1103

merged 10 commits into from
Jan 8, 2015

Conversation

stuartf
Copy link
Contributor

@stuartf stuartf commented Jan 7, 2015

requesting pull of this from oaeproject repo so that travis will upload the logs when it fails

@stuartf stuartf mentioned this pull request Jan 7, 2015
Closed
@simong
Copy link
Contributor

simong commented Jan 7, 2015

From those logs

[2015-01-07T18:43:51.511Z] ERROR: oae-preview-processor/10850 on testing-worker-linux-8-1-9724-linux-20-46226010: Could not convert the PDF to plain text (contentId=c:localhost:Qkmbo8nJE, stdout="")
    Error: Command failed: /bin/sh: 1: pdftotext: not found

        at ChildProcess.exithandler (child_process.js:648:15)
        at ChildProcess.emit (events.js:98:17)
        at maybeClose (child_process.js:756:16)
        at Process.ChildProcess._handle.onexit (child_process.js:823:5)
    --
    stderr: /bin/sh: 1: pdftotext: not found

Presumable it needs the full path towards the binary (we seem to do similar things for pdf2htmlex and pdftk)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9048ba4 on pdffulltext into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e23fa44 on pdffulltext into * on master*.

simong added a commit that referenced this pull request Jan 8, 2015
@simong
Merge pull request #1103 from oaeproject/pdffulltext
fceb46e 
Pdffulltext
@simong simong merged commit fceb46e into master Jan 8, 2015
@simong
Copy link
Contributor

simong commented Jan 8, 2015

We might need to play with scoring/boosting of documents. The cutoff point is currently set at 0.09 which might still be too high. The has_child query results in generally low document scores (as the content bodies tend to be quite large)

@mrvisser
Copy link
Contributor

mrvisser commented Jan 8, 2015

Discussing search analysis requirements sounds remarkably similar to a weather forecast :)

@simong simong deleted the pdffulltext branch January 8, 2015 12:42
nicolaasmatthijs
nicolaasmatthijs reviewed Jan 8, 2015
View reviewed changes
node_modules/oae-preview-processor/tests/test-previews.js
@@ -525,6 +525,13 @@ describe('Preview processor', function() {
assert.ok(_.find(previews.files, function(file) { return file.filename === 'page.1.html'; }));
assert.ok(!_.find(previews.files, function(file) { return file.filename === 'page.2.html'; }));

// The PDF has 1 page, there should only be 1 corresponding txt file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a test for a multi-page PDF where we verify that multiple page.x.txt files?

@stuartf stuartf mentioned this pull request Jan 8, 2015
Closed
@simong simong mentioned this pull request May 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stuartf @simong @coveralls @mrvisser @nicolaasmatthijs