Add error markers #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oakmac
reviewed
Aug 3, 2017
src-cljs/atom_parinfer/core.cljs
Outdated
| ;; Error Markers | ||
| ;;------------------------------------------------------------------------------ | ||
|
|
||
| (def error-marker-class "parinfer-error-marker") |
There was a problem hiding this comment.
Should this class be hashed like the other classnames in this extension?
There was a problem hiding this comment.
sorry, I've been trying to match your idioms in this repo, but I think this is the first user-customizable class and I thought a hash might be unnecessary here and maybe jarring to users.
oakmac
reviewed
Aug 3, 2017
src-cljs/atom_parinfer/core.cljs
Outdated
| (defn clear-error-markers | ||
| [js-editor start-row end-row js-error] | ||
| (doseq [marker (get-error-markers js-editor start-row end-row)] | ||
| (swap! error-marker-ids disj (oget marker "id")) |
There was a problem hiding this comment.
Would prefer to not see swap! inside a doseq
Can you make swap! a single operation here?
|
warning colors now
|
shaunlebron
force-pushed
the
shaun-error-markers
branch
from
345d205
to
cdc4561
Compare
|
Does the CSS require the |
|
i thought it was, but it's not. confirmed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors are now marked with
.parinfer-error-marker. These error markers are cleared in the parent expression hack range when text is processed. If there is still an error, the marker is created again. Some enhancements can be made, but it works.