Update deps.ts for changes in send.ts #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function created to send static files (oak / send.ts) is cool, but it has a big problem: to send a file, the file is loaded completely into memory. This is a problem because, for example, if there are thousands of simultaneous requests, and there is a 1MB static file, the server will have GB's of memory occupied and will probably die. This is also a problem if there is a large file to send, even with few requests. The modifications I made send the files via Buffer, which solves the problem and makes the function scalable.
|
Please combine with #126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function created to send static files (oak / send.ts) is cool, but it has a big problem: to send a file, the file is loaded completely into memory. This is a problem because, for example, if there are thousands of simultaneous requests, and there is a 1MB static file, the server will have GB's of memory occupied and will probably die. This is also a problem if there is a large file to send, even with few requests. The modifications I made send the files via Buffer, which solves the problem and makes the function scalable.