Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MiddlewareObject #589

Merged
merged 8 commits into from
Apr 25, 2023
Merged

feat: add MiddlewareObject #589

merged 8 commits into from
Apr 25, 2023

Conversation

Symbitic
Copy link
Contributor

@Symbitic Symbitic commented Mar 3, 2023

This extends Middleware to allow objects to be used, making it similar to event targets.
It allows an optional init method that will be invoked when listen is called.

Objects will be useful for encapsulating larger amounts of logic or state, or when delayed initialization is desired such as a database driver.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@Symbitic Symbitic marked this pull request as ready for review March 13, 2023 20:52
@Symbitic
Copy link
Contributor Author

@kitsonk Any idea if/when this can be merged? It will be really useful for large-scale things like Databases.

Copy link
Collaborator

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did make some minor tweaks.

@kitsonk kitsonk merged commit b875eec into oakserver:main Apr 25, 2023
1 check passed
@Symbitic Symbitic deleted the patch-1 branch April 26, 2023 04:42
@Symbitic
Copy link
Contributor Author

Great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants