Try adding support for ignore modules by regular expression pattern #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this @nicomen! This was something I had thought about, but ended up working around it by using long lists of modules to ignore. :) |
oalders
requested changes
Jun 9, 2021
|
The tests are failing on |
|
Did my new changes work out, or is it more left to fix? |
oalders
approved these changes
Jun 10, 2021
|
This is great.Thanks @nicomen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, loved your talk at TPC 2021.
You asked for pull requests. Here's one for allowing ignoring modules by regex pattern. Should be useful for instance to not touch
use MyCompany::lines, or perhaps using a pattern like^Mo(use|o|ose\b, like^Test::or similar.Perhaps the ignore-modules-pattern-filename option is excessive given that one can combine regexps but just tried to follow the same approach as ignore-modules-*