Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning #55

Closed
doctorregtools opened this issue Jul 18, 2013 · 3 comments · Fixed by #61
Closed

Warning #55

doctorregtools opened this issue Jul 18, 2013 · 3 comments · Fixed by #61

Comments

@doctorregtools
Copy link

The user agent

"SonyEricssonU1i/R1CA; Mozilla/5.0 (SymbianOS/9.4; U; Series60/5.0 Profile/MIDP-2.1 Configuration/CLDC-1.1 model-orange"

gives the following warning

Argument "1ca; mozilla/5" isn't numeric in numeric eq (==) at /opt/dianomi/perl/lib/site_perl/5.12.2/HTTP/BrowserDetect.pm line 391.

Can this be fixed?

Thanks

@oalders
Copy link
Owner

oalders commented Jul 18, 2013

Thanks for reporting this! The best way to speed this along would be if you could add this UserAgent (and the expected test results) to t/useragents.json and put this into a pull request. If that's not possible, that's fine, but any kind of contribution is helpful. :)

@mstevens
Copy link

I've made a hopefully useful pull request.

I couldn't work out the expected test results as Symbian doesn't seem to fit anything existing.

@oalders
Copy link
Owner

oalders commented Jul 18, 2013

Yep, that's useful. :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants