Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release CI more robust #126

Open
chivalryq opened this issue Jan 15, 2023 · 0 comments
Open

Make release CI more robust #126

chivalryq opened this issue Jan 15, 2023 · 0 comments

Comments

@chivalryq
Copy link
Collaborator

chivalryq commented Jan 15, 2023

Now there are two weaknesses in release CI:

  1. Checking chart version before building images: https://github.com/oam-dev/cluster-gateway/blob/master/.github/workflows/go-release.yml#L35.

This causes several pre-release failure:

This is a great check. However, its success relies that the maintainers remember to modify the chart version. We can make the chart version a placeholder and replace it in CI.

  1. The ACR domain isn't correct: https://github.com/oam-dev/cluster-gateway/blob/master/.github/workflows/go-release.yml#L72

This make the recent v1.7.0 release fail and no arm64 image builded and pushed.

Besides, there is also a suggestion: use --platform argument to distinguish the image platforms rather than including platform in tag. GitHub Action like docker/build-push-action@v2 can help with that. This makes developers' lives easier. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant