Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm install error when disable webhook patch #1483

Merged
merged 1 commit into from Apr 14, 2021

Conversation

YaoC
Copy link
Contributor

@YaoC YaoC commented Apr 14, 2021

failurePolicy should be Fail instead of Fails.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1483 (0402a3d) into master (e8ed4d7) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   52.99%   53.04%   +0.04%     
==========================================
  Files          85       85              
  Lines        8259     8259              
==========================================
+ Hits         4377     4381       +4     
+ Misses       3350     3347       -3     
+ Partials      532      531       -1     
Flag Coverage Δ
unittests 53.04% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aits/traitdefinition/traitdefinition_controller.go 81.39% <0.00%> (+9.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ed4d7...0402a3d. Read the comment docs.

@wonderflow wonderflow merged commit 8703950 into kubevela:master Apr 14, 2021
chivalryq pushed a commit to chivalryq/kubevela that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants