Keep docker binary command due to the issue #416 (#1478)

kubevela · Apr 14, 2021 · e8ed4d7 · e8ed4d7
1 parent 0c8e22e
commit e8ed4d7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -15,7 +15,6 @@ env:
   # Common versions
   GO_VERSION: '1.14'
   GOLANGCI_VERSION: 'v1.38'
-  DOCKER_BUILDX_VERSION: 'v0.4.2'
   KIND_VERSION: 'v0.7.0'
 
 jobs:

diff --git a/pkg/builtin/build/build.go b/pkg/builtin/build/build.go
@@ -101,7 +101,7 @@ func asyncLog(reader io.Reader, stream cmdutil.IOStreams) {
 // buildImage will build a image with name and context.
 func (b *Build) buildImage(io cmdutil.IOStreams, image string) error {
 	//nolint:gosec
-	// TODO(hongchaodeng): remove this dependency by using go lib
+	// keep docker binary command due to the issue #416 https://github.com/oam-dev/kubevela/issues/416
 	cmd := exec.Command("docker", "build", "-t", image, "-f", b.Docker.File, b.Docker.Context)
 	stdout, err := cmd.StdoutPipe()
 	if err != nil {