Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Commit step-generate data without success #2539

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Oct 22, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2539 (b5d67fe) into master (e56a67a) will increase coverage by 0.11%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
+ Coverage   61.71%   61.83%   +0.11%     
==========================================
  Files         182      182              
  Lines       17619    17631      +12     
==========================================
+ Hits        10874    10902      +28     
+ Misses       5545     5535      -10     
+ Partials     1200     1194       -6     
Flag Coverage Δ
apiserver-unittests 11.32% <ø> (ø)
core-unittests 55.64% <77.77%> (+0.08%) ⬆️
e2e-multicluster-test 21.28% <16.66%> (-0.01%) ⬇️
e2e-rollout-tests 31.39% <27.77%> (-0.04%) ⬇️
e2etests 37.08% <38.88%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/workflow/workflow.go 83.73% <0.00%> (ø)
pkg/workflow/context/context.go 66.01% <81.81%> (+0.73%) ⬆️
pkg/workflow/recorder/recorder.go 80.35% <100.00%> (+1.11%) ⬆️
...tepdefinition/workflowstepdefinition_controller.go 59.74% <0.00%> (-2.60%) ⬇️
...es/policydefinition/policydefinition_controller.go 60.25% <0.00%> (-2.57%) ⬇️
...pplicationrollout/applicationrollout_controller.go 83.67% <0.00%> (-1.37%) ⬇️
...dev/v1alpha2/applicationrollout/rollout_handler.go 51.97% <0.00%> (-1.32%) ⬇️
apis/standard.oam.dev/v1alpha1/rollout_state.go 71.50% <0.00%> (-1.04%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 76.96% <0.00%> (+0.60%) ⬆️
...am.dev/v1alpha2/applicationconfiguration/render.go 88.21% <0.00%> (+0.81%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56a67a...b5d67fe. Read the comment docs.

@leejanee leejanee merged commit dfbe65c into kubevela:master Oct 23, 2021
@leejanee
Copy link
Member Author

/backport 1.1

@github-actions
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.1
git worktree add -d .worktree/backport-2539-to-release-1.1 origin/release-1.1
cd .worktree/backport-2539-to-release-1.1
git checkout -b backport-2539-to-release-1.1
ancref=$(git merge-base e56a67acf57d52fd786bcb889265623d45bc9b39 b5d67fefdc309859cbbd80e89eafd6d61fc31df6)
git cherry-pick -x $ancref..b5d67fefdc309859cbbd80e89eafd6d61fc31df6

@wonderflow wonderflow changed the title Feat: Commit step-generate data without success : Commit step-generate data without success Dec 6, 2021
@wonderflow wonderflow changed the title : Commit step-generate data without success Fix: Commit step-generate data without success Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants