Feat: multicluster vela status/exec/port-forward #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
hongchaodeng,
leejanee,
wonderflow and
zzxwill
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2662 +/- ##
==========================================
- Coverage 61.72% 61.66% -0.07%
==========================================
Files 181 183 +2
Lines 17537 17703 +166
==========================================
+ Hits 10825 10916 +91
- Misses 5536 5607 +71
- Partials 1176 1180 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4 tasks
hongchaodeng
approved these changes
Nov 8, 2021
Somefive
changed the title
zzxwill
reviewed
Nov 9, 2021
Comment on lines
+59
to
+61
| endpoint := string(clusterSecret.Data["endpoint"]) | ||
| if endp, ok := clusterSecret.GetLabels()[v1alpha1.LabelKeyClusterEndpointType]; ok { | ||
| endpoint = endp |
There was a problem hiding this comment.
Why do we have two sources for endpoint?
There was a problem hiding this comment.
ClusterGateway undergoes a version update which means we need to support backward-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Support exec for pods in remote cluster. Support port-forward for workloads/service in remote cluster. Continue from #2658.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer