Fix: support naming a terraform provider #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support set the name for a terraform provider. Fix kubevela#2595
zzxwill
requested review from
barnettZQG,
hongchaodeng,
leejanee,
Somefive and
wonderflow
as code owners
wonderflow
approved these changes
Nov 24, 2021
Somefive
reviewed
Nov 24, 2021
| @@ -24,6 +24,9 @@ import ( | |||
| "text/template" | |||
| "time" | |||
|
|
|||
| terraformv1beta1 "github.com/oam-dev/terraform-controller/api/v1beta1" | |||
There was a problem hiding this comment.
maybe reorganize the imports?
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
==========================================
+ Coverage 54.86% 59.78% +4.92%
==========================================
Files 136 223 +87
Lines 13643 22904 +9261
==========================================
+ Hits 7485 13694 +6209
- Misses 5278 7542 +2264
- Partials 880 1668 +788
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hongchaodeng
approved these changes
Nov 24, 2021
Somefive
approved these changes
Nov 25, 2021
|
/backport 1.1 |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.1
git worktree add -d .worktree/backport-2794-to-release-1.1 origin/release-1.1
cd .worktree/backport-2794-to-release-1.1
git checkout -b backport-2794-to-release-1.1
ancref=$(git merge-base 3d2fcacb5a98af841b4b69995a0be204f6062c81 548143a00443000493811854867c5c37572c35b2)
git cherry-pick -x $ancref..548143a00443000493811854867c5c37572c35b2 |
zzxwill
added a commit
to zzxwill/kubevela
that referenced
this pull request
Nov 29, 2021
- Fix: upgrade terraform controller to v0.2.10 kubevela#2827 - Fix: support naming a terraform provider kubevela#2794
4 tasks
zzxwill
added a commit
to zzxwill/kubevela
that referenced
this pull request
Nov 30, 2021
- Fix: upgrade terraform controller to v0.2.10 kubevela#2827 - Fix: support naming a terraform provider kubevela#2794 Signed-off-by: zzxwill <zzxwill@gmail.com>
zzxwill
added a commit
to zzxwill/kubevela
that referenced
this pull request
Nov 30, 2021
- Fix: upgrade terraform controller to v0.2.10 kubevela#2827 - Fix: support naming a terraform provider kubevela#2794 Signed-off-by: zzxwill <zzxwill@gmail.com>
wonderflow
pushed a commit
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support set the name for a terraform provider.
Fix #2595
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer