-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove annotation for apiversion and kind, use discoverymapper instead #584
Conversation
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
UT failure:
|
Please update the extending kubevela doc. |
@resouer already updated |
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 17.72% 17.94% +0.21%
==========================================
Files 61 61
Lines 5240 5245 +5
==========================================
+ Hits 929 941 +12
+ Misses 4168 4157 -11
- Partials 143 147 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
fix #572
Signed-off-by: 天元 jianbo.sjb@alibaba-inc.com