Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annotation for apiversion and kind, use discoverymapper instead #584

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

wonderflow
Copy link
Collaborator

fix #572
Signed-off-by: 天元 jianbo.sjb@alibaba-inc.com

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hongchaodeng
Copy link
Member

UT failure:

pkg/server/handler/capabilityHandlers.go:46:42: not enough arguments in call to "github.com/oam-dev/kubevela/pkg/oam".AddCapabilityIntoCluster
	have (client.Client, string)
	want (client.Client, discoverymapper.DiscoveryMapper, string)

@resouer
Copy link
Collaborator

resouer commented Nov 12, 2020

Please update the extending kubevela doc.

@wonderflow
Copy link
Collaborator Author

@resouer already updated

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #584 (4f4210f) into master (16ddba8) will increase coverage by 0.21%.
The diff coverage is 17.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   17.72%   17.94%   +0.21%     
==========================================
  Files          61       61              
  Lines        5240     5245       +5     
==========================================
+ Hits          929      941      +12     
+ Misses       4168     4157      -11     
- Partials      143      147       +4     
Flag Coverage Δ
unittests 17.94% <17.28%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/commands/capability.go 0.00% <0.00%> (ø)
pkg/commands/dashboard.go 0.00% <0.00%> (ø)
pkg/commands/env.go 29.56% <0.00%> (ø)
pkg/commands/refresh.go 0.00% <ø> (ø)
pkg/commands/system.go 0.00% <0.00%> (ø)
pkg/commands/traits.go 28.57% <0.00%> (+2.76%) ⬆️
pkg/commands/util/helpers.go 0.00% <ø> (ø)
pkg/commands/workloads.go 0.00% <0.00%> (ø)
pkg/oam/capability.go 0.00% <0.00%> (ø)
pkg/oam/common.go 33.33% <0.00%> (-3.04%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ddba8...d67ce4d. Read the comment docs.

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Using discoveryMapper to get apiversion and kind from definition
3 participants