This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
resolve variables #264
Merged
resolve variables #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fibonacci1729 , can you take a look and reply my comment at #70 (comment) Thanks! |
technosophos
approved these changes
Oct 3, 2019
| use regex::Regex; | ||
|
|
||
| fn parse_from_variable(input: String) -> Option<String> { | ||
| lazy_static! { |
There was a problem hiding this comment.
On lazy_static!, where have you been all my life?
| .collect() | ||
| } | ||
|
|
||
| // TODO: variables are unique per config should redefinition should be an error. |
There was a problem hiding this comment.
I think dedup can be done silently. I don't think an error is necessary.
| if let serde_json::Value::String(s) = value { | ||
| if let Some(ref var) = parse_from_variable(s.clone()) { | ||
| param.value = vars.get(var).map(|var| var.clone()); | ||
| ensure!(param.value.is_some(), format!( |
There was a problem hiding this comment.
Ooo... I didn't know about ensure! either!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #70