Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad taiko converter #103

Open
1 of 2 tasks
acrylic-style opened this issue Mar 26, 2021 · 4 comments · Fixed by #110
Open
1 of 2 tasks

Bad taiko converter #103

acrylic-style opened this issue Mar 26, 2021 · 4 comments · Fixed by #110
Assignees
@acrylic-style
Labels
bug

Comments

@acrylic-style
Copy link
Collaborator

acrylic-style commented Mar 26, 2021 •
edited
Loading

Describe the bug
How am I didn't notice this bug 🤔 (the screenshot was taken on old commit)
image

To Reproduce
Steps to reproduce the behavior:

  1. calculate star rating for taiko map

Expected behavior
show 5.76*

Environment (please complete the following information):
@acrylic-style

This comment has been minimized.

Sign in to view
acrylic-style added a commit to acrylic-style/ezpp that referenced this issue Mar 26, 2021
@acrylic-style
Full taiko support
e584e5a 
- and garbages that will be used to support ctb
- help me (oamaok#103)
@acrylic-style
Copy link
Collaborator Author

acrylic-style commented Mar 27, 2021 •
edited
Loading

things need to be done:

  • nothing

@acrylic-style acrylic-style mentioned this issue Mar 27, 2021
Merged
@acrylic-style acrylic-style changed the title Wrong star rating Wrong star rating / bad taiko converter Mar 27, 2021
oamaok pushed a commit that referenced this issue Apr 3, 2021
@acrylic-style
Full taiko star rating/pp calculation (#110)
72006b2 
* Full taiko support

- and garbages that will be used to support ctb
- help me (#103)

* remove +1

* :(

* Some maps will work from now, conversion maps are still broken

* finally, works on most maps!

* fix style

* wow, converter issues are very complex

* I think it's done

* remove debug stuff

* Remove ctb related code

* Remove .vscode
@acrylic-style acrylic-style pinned this issue Apr 3, 2021
@acrylic-style
Copy link
Collaborator Author

acrylic-style commented Apr 20, 2021 •
edited
Loading

image
max combo seems still broken. (only for conversion maps, non-conversion maps are completely fine)

@acrylic-style acrylic-style reopened this Apr 20, 2021
@acrylic-style acrylic-style changed the title Wrong star rating / bad taiko converter Bad taiko converter Apr 20, 2021
@acrylic-style acrylic-style mentioned this issue Apr 22, 2021
Closed
@acrylic-style
Copy link
Collaborator Author

It's actually still an issue, but only on few maps. See acrylic-style#4

@acrylic-style acrylic-style reopened this Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acrylic-style acrylic-style

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@oamaok @acrylic-style