Prevent report and report_json being used if returncode is 0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywaltlova
approved these changes
Dec 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 2 2
Lines 491 491
=======================================
Hits 490 490
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
r0x0d
force-pushed
the
dont-show-report-in-success
branch
from
7669cf5
to
2ab1c01
Compare
r0x0d
commented
Dec 1, 2023
Comment on lines
+83
to
+84
| assert mock_gather_textual_report.call_count == 0 | ||
| assert mock_transform_raw_data.call_count == 0 |
There was a problem hiding this comment.
The tests had to be changed because the way we are mocking the run_convert2rhel function is that we are returning a return code 0, meaning that we won't collect the textual report and not transform the raw data to display in insights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.