[RHELC-784] Allow but warn about deprecated env var #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've renamed CONVERT2RHEL_UNSUPPORTED_VERSION to CONVERT2RHEL_ALLOW_OLDER_VERSION. Allow the old env var name to be used but emit a deprecation warning in the log. Add unittests to show the deprecation message is emitted when we use the old env var rather than the new one to allow the conversion to continue.
Codecov ReportBase: 93.41% // Head: 93.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 93.41% 93.42%
=======================================
Files 22 22
Lines 3115 3118 +3
Branches 553 554 +1
=======================================
+ Hits 2910 2913 +3
Misses 143 143
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Re-running one integration test as it seems to be failing because of infrastructure problems. |
r0x0d
reviewed
Nov 3, 2022
abadger
commented
Nov 3, 2022
Venefilyn
changed the title
|
The test All errors seem to not be related to the PR. Merging this right now. |
hosekadam
pushed a commit
to hosekadam/convert2rhel
that referenced
this pull request
Nov 11, 2022
* Allow but warn about deprecated env var We've renamed CONVERT2RHEL_UNSUPPORTED_VERSION to CONVERT2RHEL_ALLOW_OLDER_VERSION. Allow the old env var name to be used but emit a deprecation warning in the log. Add unittests to show the deprecation message is emitted when we use the old env var rather than the new one to allow the conversion to continue. * Update convert2rhel/unit_tests/checks_test.py
Merged
abadger
added a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Dec 7, 2022
* Allow but warn about deprecated env var We've renamed CONVERT2RHEL_UNSUPPORTED_VERSION to CONVERT2RHEL_ALLOW_OLDER_VERSION. Allow the old env var name to be used but emit a deprecation warning in the log. Add unittests to show the deprecation message is emitted when we use the old env var rather than the new one to allow the conversion to continue. * Update convert2rhel/unit_tests/checks_test.py
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Allow but warn about deprecated env var We've renamed CONVERT2RHEL_UNSUPPORTED_VERSION to CONVERT2RHEL_ALLOW_OLDER_VERSION. Allow the old env var name to be used but emit a deprecation warning in the log. Add unittests to show the deprecation message is emitted when we use the old env var rather than the new one to allow the conversion to continue. * Update convert2rhel/unit_tests/checks_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've renamed CONVERT2RHEL_UNSUPPORTED_VERSION to CONVERT2RHEL_ALLOW_OLDER_VERSION. Allow the old env var name to be used but emit a deprecation warning in the log.
Add unittests to show the deprecation message is emitted when we use the old env var rather than the new one to allow the conversion to continue.
Followup to changes introduced for: #566
Jira Issue: RHELC-784
Checklist
[RHELC-]is part of the PR titleRelease Pending