style: Black formatting showcase #68
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Venefilyn
changed the title
|
from my perspective the biggest benefit of the black formating is that we're no longer discussing a code style. It is just one, uncompromised. This saves a lot of time. |
I agree 100%. I'm sure we will run into differences between pylint and black that need to be resolved though. Especially given we use pylint 1.9 rather than 2+ |
Never tried:) |
| loggerinst.warning("By continuing all further changes on the system" | ||
| " will need to be reverted manually by the user," | ||
| " if necessary.") | ||
| loggerinst.warning("The tool allows rollback of any action until this" " point.") |
There was a problem hiding this comment.
Only bug I've seen so far is the lack of handling of multi-line strings, here it doesn't merge the strings but just brings them to the same line
|
@SpyTec Please resolve the conflicting files, if you still want to merge this PR. |
We'll open a new PR once we've had a larger discussion with OAMG and this is something we'd want to pursue. Can remain open for now |
|
I assume next week to make a MR which will be including the black formatter as well. I’ll ping you once it is ready and, ideally, we can do absolutely the same for c2r |
|
Just an update: have to postpone the work on black formatter to the next week |
|
One more update. Guys, I have to postpone the work on the feature, due to another, more important tasks. Please follow the progress here - OAMG-3458. I won't give any next date term, since already now feeling bad about this. So, I just will try to do this ASAP, since pre-commits hooks, black formatting really a huge boost to most of the devs performance |
No rush! It is relatively low priority compared to other tasks on our side as well :) |
Showcase of what would be changed using black. Refer to #67