Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1246] Fix failing subscription-manager installation on EL8 #991

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Nov 22, 2023

Yumdownloader was downloading two different versions of the subscription-manager-rhsm-certificates package and convert2rhel failed when it wanted to install both at the same time.

subscription-manager-rhsm-certificates-1.28.36-3.el8_8.x86_64 subscription-manager-rhsm-certificates-20220623-1.el8.noarch

Pino Toscano from the subscription-manager team told us that the version 20220623 is the latest and the one we should be installing.

Since the two versions have different architecture, this quick solution is making sure that only the noarch one is downloaded and installed.

The same applies to conversions to RHEL 9. We were downloading incorrectly the x86_64 version of the package which is not the latest.

Jira Issues: RHELC-1246

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Yumdownloader was downloading two different versions of the
subscription-manager-rhsm-certificates package and convert2rhel failed
when it wanted to install both at the same time.

subscription-manager-rhsm-certificates-1.28.36-3.el8_8.x86_64
subscription-manager-rhsm-certificates-20220623-1.el8.noarch

Pino Toscano from the subscription-manager team told us that the version
20220623 is the latest and the one we should be installing.

Since the two versions have different architecture, this quick solution
is making sure that only the noarch one is downloaded and installed.
@bocekm bocekm requested a review from danmyway November 22, 2023 23:55
@bocekm bocekm added the tests-run-tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. label Nov 22, 2023
@has-bot
Copy link
Member

has-bot commented Nov 22, 2023

/packit test --labels tier0


@oamg/conversions-qe please review results and provide ack.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7decb7e) 94.21% compared to head (af4bd02) 94.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          47       47           
  Lines        4377     4377           
  Branches      775      775           
=======================================
  Hits         4124     4124           
  Misses        177      177           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 89.18% <ø> (ø)
centos-linux-8 90.24% <ø> (ø)
centos-linux-9 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway
Copy link
Member

/packit test --labels sanity

Copy link
Member

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails unrelated, will be fixed in #988
The subscription-manager package is being correctly installed.
Could be merged.

@Venefilyn Venefilyn added the bug-fix A bug has been fixed label Nov 23, 2023
@bocekm bocekm merged commit 45cc026 into oamg:main Nov 23, 2023
25 of 71 checks passed
@bocekm bocekm changed the title [RHELC-1246] Fix sub-man installation on EL8 [RHELC-1246] Fix failing subscription-manager installation on EL8 Nov 23, 2023
hosekadam pushed a commit to hosekadam/convert2rhel that referenced this pull request Nov 24, 2023
Yumdownloader was downloading two different versions of the
subscription-manager-rhsm-certificates package and convert2rhel failed
when it wanted to install both at the same time.

subscription-manager-rhsm-certificates-1.28.36-3.el8_8.x86_64
subscription-manager-rhsm-certificates-20220623-1.el8.noarch

Pino Toscano from the subscription-manager team told us that the version
20220623 is the latest and the one we should be installing.

Since the two versions have different architecture, this quick solution
is making sure that only the noarch one is downloaded and installed.
bocekm added a commit to bocekm/convert2rhel that referenced this pull request Nov 29, 2023
The oamg#991 was dealing with a
convert2rhel failure stemming from two different architectures of the
subscription-manager-rhsm-certificates package being available in UBI
repos. That fix however caused convert2rhel failures on older system minor
versions where only x86_64 arch was available.

In the meantime Pino Toscano asked to have the UBI repos fixed in a way
that there is now just one architecture of the package. With that we
don't need to hardcode a specific arch in convert2rhel.
@bocekm bocekm added no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. and removed bug-fix A bug has been fixed labels Nov 29, 2023
Venefilyn pushed a commit that referenced this pull request Nov 30, 2023
The #991 was dealing with a
convert2rhel failure stemming from two different architectures of the
subscription-manager-rhsm-certificates package being available in UBI
repos. That fix however caused convert2rhel failures on older system minor
versions where only x86_64 arch was available.

In the meantime Pino Toscano asked to have the UBI repos fixed in a way
that there is now just one architecture of the package. With that we
don't need to hardcode a specific arch in convert2rhel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-run-tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants