Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leapp::Api::PreupgradeReportsController #27

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Leapp::Api::PreupgradeReportsController #27

merged 2 commits into from
Apr 1, 2020

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Mar 30, 2020 •
edited
Loading

Requires #17

Info:

  • Remove obsole create action (it was used for preupgrade callback)
  • Add index
  • Add rabl templates
  • Remove obsolete controllers

@stejskalleos stejskalleos mentioned this pull request Mar 30, 2020
Closed
xprazak2
xprazak2 reviewed Mar 31, 2020
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
xprazak2
xprazak2 reviewed Mar 31, 2020
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
@xprazak2
Copy link
Contributor

xprazak2 commented Mar 31, 2020 •
edited
Loading

Nice work, it would be good to have some basic tests.

@stejskalleos
Copy link
Contributor Author

Updated + added tests for Api controller.

adamruzicka
adamruzicka approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@adamruzicka adamruzicka merged commit 7f5e910 into theforeman:master Apr 1, 2020
@adamruzicka
Copy link
Contributor

Thank you @stejskalleos & @xprazak2 !

@xprazak2 xprazak2 mentioned this pull request Apr 2, 2020
Closed
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xprazak2 xprazak2 xprazak2 left review comments

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stejskalleos @xprazak2 @adamruzicka