Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend leappdb with more execution information #1152

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

dkubek
Copy link
Member

@dkubek dkubek commented Nov 21, 2023

Related to changes extending the information stored in the leapp db. After this comment, the command line arguments as well as the environment variables modifying the leapp execution (env vars starting with LEAPP_) will be stored in the database.

JIRA: OAMG-8402

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 marked this pull request as draft November 21, 2023 14:43
@dkubek dkubek added the WIP Work In Progress label Nov 23, 2023
@pirat89 pirat89 added this to the 8.10/9.5 milestone Jan 29, 2024
@pirat89
Copy link
Member

pirat89 commented May 9, 2024

I've rebased the branch against up-to-date upstream.

Related to changes extending the information stored in the leapp db.
After this comment, the command line arguments as well as the
environment variables modifying the leapp execution (env vars starting
with `LEAPP_`) will be stored in the database.

Works on: OAMG-8402
@dkubek dkubek removed the WIP Work In Progress label May 22, 2024
@dkubek dkubek changed the title [Draft] Extend leappdb with more execution information Extend leappdb with more execution information May 22, 2024
@dkubek dkubek marked this pull request as ready for review May 22, 2024 09:05
@pirat89 pirat89 added the enhancement New feature or request label May 22, 2024
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@pirat89
Copy link
Member

pirat89 commented May 22, 2024

Work like a charm:

# leapp preupgrade --debug --channel ga --no-rhsm
...
# sqlite3 /var/lib/leapp/leapp.db
sqlite> select * from execution;
...
7|1bba4374-2a9b-4bd0-a917-3178474d3a63|2024-05-22T09:55:13.396744Z|{"cmd": ["/usr/bin/leapp", "preupgrade", "--debug", "--channel", "ga", "--no-rhsm"], "debug": "1", "environment": {"LEAPP_DEBUG": "1", "LEAPP_DEVEL_DATABASE_SYNC_OFF": "1", "LEAPP_DEVEL_USE_PERSISTENT_PACKAGE_CACHE": "1", "LEAPP_EXPERIMENTAL": "0", "LEAPP_HOSTNAME": "localhost.localdomain", "LEAPP_IPU_IN_PROGRESS": "7to8", "LEAPP_NO_RHSM": "1", "LEAPP_NO_RHSM_FACTS": "1", "LEAPP_TARGET_PRODUCT_CHANNEL": "ga", "LEAPP_UNSUPPORTED": "1", "LEAPP_UPGRADE_PATH_FLAVOUR": "default", "LEAPP_UPGRADE_PATH_TARGET_RELEASE": "8.10", "LEAPP_VERBOSE": "1"}, "verbose": "1", "whitelist_experimental": []}|preupgrade

@pirat89 pirat89 merged commit ae387bc into oamg:master May 22, 2024
12 of 13 checks passed
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants