Fix another cornercase with symlink handling #1166

abadger · 2024-01-22T06:04:57Z

There are two commits in this PR. We may want to defer the second one until after the release, though:
First change:

Fixes symlinks to a directory inside of /etc/pki were being created as empty directories.

Second change:

Fixes two links to the same file outside of /etc/pki should be created as a copy of the file and a link to that copy.

Another part of the fix for: https://issues.redhat.com/browse/RHEL-3284

Related PRs: #1135, #1160

* Symlinks to a directory inside of /etc/pki were being created as empty directories. * Note: unittests being added for both this problem and a second problem: two links to the same external file will be copied as two separate files but ideally we want one to be a copy and the other to link to the copy. The unittests for the second problem are commented out. Fixes: https://issues.redhat.com/browse/RHEL-3284

github-actions · 2024-01-22T06:05:09Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please @oamg/developers to notify leapp developers of the review request
/packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

/packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
/packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

/rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
/rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
/rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
/rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 · 2024-01-22T12:11:00Z

tl;dr; discovered one bug introduced by the last commit for corner cases. see the bottom of the comment

Manually tested. Commands just for dirs:

# mkdir /var/lib/leapp/adir
# touch /var/lib/leapp/adir/afile
# cd /etc/pki/
# ln -s ca-trust my-dir-symlink-relative
# ln -s /etc/pki/ca-trust my-dir-symlink-absolute
# ln -s /var/lib/leapp/adir absolute-outside-dir-symlink
# mkdir mydir
# cd mydir/
# ln -s ../ca-trust/source/anchors/RH-IT-Root-CA.crt nested-symlink-to-file-in-a-symlinked-dir
# cd ..
# ln -s mydir mydir-symlink-relative-nested

The results for dirs (first commit only):

[root@localhost el8userspace]# ls -l `find /etc/pki -type l`
lrwxrwxrwx. 1 root root 19 Jan 22 12:35 /etc/pki/absolute-outside-dir-symlink -> /var/lib/leapp/adir
lrwxrwxrwx. 1 root root 59 Jan 12 13:01 /etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt
lrwxrwxrwx. 1 root root 40 Jan 12 13:01 /etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts
lrwxrwxrwx. 1 root root 44 Jan 22 12:36 /etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt
lrwxrwxrwx. 1 root root 17 Jan 22 12:34 /etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust
lrwxrwxrwx. 1 root root  8 Jan 22 12:33 /etc/pki/my-dir-symlink-relative -> ca-trust
lrwxrwxrwx. 1 root root  5 Jan 22 12:37 /etc/pki/mydir-symlink-relative-nested -> mydir
lrwxrwxrwx. 1 root root 49 Jan 12 13:01 /etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
lrwxrwxrwx. 1 root root 49 Jan 12 13:01 /etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
lrwxrwxrwx. 1 root root 55 Jan 12 13:01 /etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt
[root@localhost el8userspace]# ls -l `find etc/pki -type l`
lrwxrwxrwx. 1 root root 59 Jan 22 12:38 etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt
lrwxrwxrwx. 1 root root 40 Jan 22 12:38 etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts
lrwxrwxrwx. 1 root root 44 Jan 22 12:38 etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt
lrwxrwxrwx. 1 root root 17 Jan 22 12:38 etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust
lrwxrwxrwx. 1 root root  8 Jan 22 12:38 etc/pki/my-dir-symlink-relative -> ca-trust
lrwxrwxrwx. 1 root root  5 Jan 22 12:38 etc/pki/mydir-symlink-relative-nested -> mydir
lrwxrwxrwx. 1 root root 49 Jan 22 12:38 etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
lrwxrwxrwx. 1 root root 49 Jan 22 12:38 etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
lrwxrwxrwx. 1 root root 55 Jan 22 12:38 etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt

CMDs for additional tests:

# cd /etc/pki
# echo hura > /etc/pki/oamg5073-custom-file
# echo 'heureka!' > /var/lib/leapp/oamg5073-custom-file-out-of-pki
# ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
# ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink
# ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki /etc/pki/oamg5073-custom-file-out-of-pki-absolute
# ln -s /nonexistent-file oamg5073-broken-symlink-absolute
# ln -s /nonexistent-file oamg5073-broken-symlink-absolut
# ln -s nonexistent-file-relative oamg5073-broken-symlink-relative-inside
# ln -s /etc/pki/oamg5073-custom-file oamg5073-custom-file-symlink-absolute
# ln -s ../oamg5073-custom-file /etc/pki/mydir/oamg5073-custom-file-symlink-relative-in
# ln -s ../pki/oamg5073-custom-file oamg5073-custom-file-symlink-relative-out-in

Update: dropped raw output, as I updated in the meanwhile the cmds above and orig results would not fit in some cases. So keeping just interpretted formatted results.

Better view of the results + another outputs when needed (for both commits):

### paired symlinks, created and kept (ok part)
/etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt
 etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt

/etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts
 etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts

/etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt
 etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt

/etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust
 etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust

/etc/pki/my-dir-symlink-relative -> ca-trust
 etc/pki/my-dir-symlink-relative -> ca-trust

/etc/pki/mydir-symlink-relative-nested -> mydir
 etc/pki/mydir-symlink-relative-nested -> mydir

/etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
 etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem

/etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
 etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem

/etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt
 etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt

... 
===========================================
                                                                               
### broken symlinks skipped (OK)                                                
/etc/pki/oamg5073-broken-symlink-absolut -> /nonexistent-file                      
/etc/pki/oamg5073-broken-symlink-relative-inside -> nonexistent-file-relative   
                                                                                
                                                                                
### outside symlinks transformed to real files (OK)                             
/etc/pki/absolute-outside-dir-symlink -> /var/lib/leapp/adir                    
                                                                                
# ls -ld etc/pki/absolute-outside-dir-symlink                                   
drwxr-xr-x. ... etc/pki/absolute-outside-dir-symlink

however, current results are weird for transient symlinks, which points in the end to the same file (FAILED):

### on the host system
#### absolut-symlink-outside-etc-pki -> /var/lib/leapp/*custom-file-out-of-pki  
[root@localhost el8userspace]# ls -l /etc/pki/oamg5073-custom-file-out-of-pki-absolute /var/lib/leapp/oamg5073-custom-file-out-of-pki
lrwxrwxrwx. 1 root root 46 Jan 22 12:54 /etc/pki/oamg5073-custom-file-out-of-pki-absolute -> /var/lib/leapp/oamg5073-custom-file-out-of-pki
-rw-r--r--. 1 root root  9 Jan 22 12:53 /var/lib/leapp/oamg5073-custom-file-out-of-pki


#### and also: symlink -> symlink -> /var/lib/leapp/oamg5073-custom-file-out-of-pki
[root@localhost el8userspace]# ls -l /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink  /var/lib/leapp/oamg5073-custom-file-out-of-pki
lrwxrwxrwx. 1 root root 54 Jan 22 12:53 /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive -> /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink
lrwxrwxrwx. 1 root root 46 Jan 22 12:54 /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink -> /var/lib/leapp/oamg5073-custom-file-out-of-pki
-rw-r--r--. 1 root root  9 Jan 22 12:53 /var/lib/leapp/oamg5073-custom-file-out-of-pki

### inside the container (FAIL)
[root@localhost el8userspace]# ls -l etc/pki/oamg5073-custom-file-out-of-pki-absolute
lrwxrwxrwx. 1 root root 60 Jan 22 13:34 etc/pki/oamg5073-custom-file-out-of-pki-absolute -> /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
[root@localhost el8userspace]# ls -l etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
-rw-r--r--. 1 root root 9 Jan 22 12:53 etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive

In the last case, I would expect to see inside the container 2 real files:

 etc/pki/oamg5073-custom-file-out-of-pki-absolute
 etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive

I would not expect that etc/pki/oamg5073-custom-file-out-of-pki-absolute will be symlink to a file to which by name never pointed before. I am going to try all tests one more time on the first commit only. It seems the first commits is working as expected. Let's sync yet when zou are online @abadger

pirat89 · 2024-01-22T15:09:38Z

@abadger seems for the first commit everything works as expected. Just for the second one I see a problem.

CMDs for the setup (dropping hashtag for easier copy & paste):

mkdir /var/lib/leapp/adir
touch /var/lib/leapp/adir/afile
cd /etc/pki/
ln -s ca-trust my-dir-symlink-relative
ln -s /etc/pki/ca-trust my-dir-symlink-absolute
ln -s /var/lib/leapp/adir absolute-outside-dir-symlink
mkdir mydir
cd mydir/
ln -s ../ca-trust/source/anchors/RH-IT-Root-CA.crt nested-symlink-to-file-in-a-symlinked-dir
cd ..
ln -s mydir mydir-symlink-relative-nested

cd /etc/pki
echo hura > /etc/pki/oamg5073-custom-file
echo 'heureka!' > /var/lib/leapp/oamg5073-custom-file-out-of-pki
ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink
ln -s /var/lib/leapp/oamg5073-custom-file-out-of-pki /etc/pki/oamg5073-custom-file-out-of-pki-absolute
ln -s /nonexistent-file oamg5073-broken-symlink-absolute
ln -s /nonexistent-file oamg5073-broken-symlink-absolut
ln -s nonexistent-file-relative oamg5073-broken-symlink-relative-inside
ln -s /etc/pki/oamg5073-custom-file oamg5073-custom-file-symlink-absolute
ln -s ../oamg5073-custom-file /etc/pki/mydir/oamg5073-custom-file-symlink-relative-in
ln -s ../pki/oamg5073-custom-file oamg5073-custom-file-symlink-relative-out-in

Results for the first commit:

# paired symlinks (OK)
/etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt
 etc/pki/ca-trust/source/ca-bundle.legacy.crt -> /usr/share/pki/ca-trust-legacy/ca-bundle.legacy.default.crt

/etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts
 etc/pki/java/cacerts -> /etc/pki/ca-trust/extracted/java/cacerts

/etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt
 etc/pki/mydir/nested-symlink-to-file-in-a-symlinked-dir -> ../ca-trust/source/anchors/RH-IT-Root-CA.crt

/etc/pki/mydir/oamg5073-custom-file-symlink-relative-in -> ../oamg5073-custom-file
 etc/pki/mydir/oamg5073-custom-file-symlink-relative-in -> ../oamg5073-custom-file

/etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust
 etc/pki/my-dir-symlink-absolute -> /etc/pki/ca-trust

/etc/pki/my-dir-symlink-relative -> ca-trust
 etc/pki/my-dir-symlink-relative -> ca-trust

/etc/pki/mydir-symlink-relative-nested -> mydir
 etc/pki/mydir-symlink-relative-nested -> mydir

/etc/pki/oamg5073-custom-file-symlink-absolute -> /etc/pki/oamg5073-custom-file
 etc/pki/oamg5073-custom-file-symlink-absolute -> /etc/pki/oamg5073-custom-file

/etc/pki/oamg5073-custom-file-symlink-relative-out-in -> ../pki/oamg5073-custom-file
 etc/pki/oamg5073-custom-file-symlink-relative-out-in -> oamg5073-custom-file

/etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
 etc/pki/tls/cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem

/etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
 etc/pki/tls/certs/ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem

/etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt
 etc/pki/tls/certs/ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt

################################
### ignored broken symlinks (OK)
/etc/pki/oamg5073-broken-symlink-absolut -> /nonexistent-file
/etc/pki/oamg5073-broken-symlink-relative-inside -> nonexistent-file-relative

[root@localhost el8userspace]# ls -l etc/pki/oamg5073-broken-symlink-absolut etc/pki/oamg5073-broken-symlink-relative-inside
ls: cannot access etc/pki/oamg5073-broken-symlink-absolut: No such file or directory
ls: cannot access etc/pki/oamg5073-broken-symlink-relative-inside: No such file or directory

### symlinks pointing outside of /etc/pki, transformed to real files (OK)
* /etc/pki/absolute-outside-dir-symlink -> /var/lib/leapp/adir

[root@localhost el8userspace]# ls -ld etc/pki/absolute-outside-dir-symlink
drwxr-xr-x. 2 root root 19 Jan 22 12:34 etc/pki/absolute-outside-dir-symlink

* /etc/pki/oamg5073-custom-file-out-of-pki-absolute -> /var/lib/leapp/oamg5073-custom-file-out-of-pki

[root@localhost el8userspace]# ls -ld /etc/pki/oamg5073-custom-file-out-of-pki-absolute etc/pki/oamg5073-custom-file-out-of-pki-absolute
lrwxrwxrwx. 1 root root 46 Jan 22 12:54 /etc/pki/oamg5073-custom-file-out-of-pki-absolute -> /var/lib/leapp/oamg5073-custom-file-out-of-pki
-rw-r--r--. 1 root root  9 Jan 22 12:53 etc/pki/oamg5073-custom-file-out-of-pki-absolute
[root@localhost el8userspace]# cat /var/lib/leapp/oamg5073-custom-file-out-of-pki etc/pki/oamg5073-custom-file-out-of-pki-absolute
heureka!
heureka!

* /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive -> /var/lib/leapp/oamg5073-custom-file-out-of-pki-symlink

[root@localhost el8userspace]# ls -ld etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
-rw-r--r--. 1 root root 9 Jan 22 12:53 etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
[root@localhost el8userspace]# cat /etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
heureka!

abadger · 2024-01-22T16:31:21Z

In the last case, I would expect to see inside the container 2 real files:
 etc/pki/oamg5073-custom-file-out-of-pki-absolute
 etc/pki/oamg5073-custom-file-out-of-pki-absolute-transitive
I would not expect that etc/pki/oamg5073-custom-file-out-of-pki-absolute will be symlink to a file to which by name never pointed before. I am going to try all tests one more time on the first commit only. It seems the first commits is working as expected. Let's sync yet when zou are online @abadger

So ... this is what the second commit is designed to do but we should have a discussion of whether it is correct behaviour or not.

Con:

(as you say) It could be confusing to the end user that two links whose next link in their chains are different end up as one real file and a link pointing to it.

Pro:

On the host system, any changes the user makes to the first link will change what's present in the second link and vice versa (since they are the same underlying file). If we break that association with two separate real files, then the user would have to edit both files to have the same outcome.

(We can also move the second commit to a different PR so we can discuss it for the next release instead of this one.)

abadger · 2024-01-22T16:43:10Z

@pirat89 and I discussed and decided we will separate the second commit into a different PR but we will discuss it more this week before deciding whether to put it into this release, next release, or decide the behaviour is unwanted.

pirat89

see my previous test results. lgtm and works. We will discuss yet how about the second commit that has been separated to its own PR.

## Packaging - Requires xfsprogs and e2fsprogs (oamg#1154) - Bump leapp-repository-dependencies to 10 (oamg#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (oamg#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (oamg#1120) - Drop the invalid `tuv` target channel (oamg#1130) - Fix handling of symlinks under /etc/pki when managing certificates (oamg#1135, oamg#1160, oamg#1166) - Fix semanage import issue (oamg#1164) - Fix the issue of going out of bounds in the isccfg parser (oamg#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (oamg#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (oamg#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (oamg#1134) - Minor updates of generated reports (oamg#1151) - Print nice error msg when device and driver deprecation data is malformed (oamg#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (oamg#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (oamg#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (oamg#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (oamg#1136, oamg#1138) ### Enhancements - Update upgrade paths: (oamg#1146, oamg#1147, oamg#1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (oamg#1143) - Code cleaning: drop redundant and invalid NFS checks (oamg#1127) - Default to NO_RHSM mode when subscription-manager is not found (oamg#1133) - Detect customized configuration of dynamic linker (oamg#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (oamg#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (oamg#1175) - Ignore Leapp related PES events (oamg#1153) - Introduce generic transition of systemd services states during the IPU (oamg#1060, oamg#1174) - Introduce possibility to upgrade with local repositories (oamg#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (oamg#1140) - Report the upgrade customisations and modifications of the upgrade tooling (oamg#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (oamg#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (oamg#1163, oamg#1165, oamg#1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (oamg#1137, oamg#1165, oamg#1172) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (oamg#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (oamg#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (oamg#876)

## Packaging - Requires xfsprogs and e2fsprogs (oamg#1154) - Bump leapp-repository-dependencies to 10 (oamg#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (oamg#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (oamg#1120) - Drop the invalid `tuv` target channel (oamg#1130) - Fix handling of symlinks under /etc/pki when managing certificates (oamg#1135, oamg#1160, oamg#1166) - Fix semanage import issue (oamg#1164) - Fix the issue of going out of bounds in the isccfg parser (oamg#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (oamg#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (oamg#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (oamg#1134) - Minor updates of generated reports (oamg#1151) - Print nice error msg when device and driver deprecation data is malformed (oamg#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (oamg#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (oamg#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (oamg#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (oamg#1136, oamg#1138) ### Enhancements - Update upgrade paths: (oamg#1146, oamg#1147, oamg#1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (oamg#1143) - Code cleaning: drop redundant and invalid NFS checks (oamg#1127) - Default to NO_RHSM mode when subscription-manager is not found (oamg#1133) - Detect customized configuration of dynamic linker (oamg#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (oamg#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (oamg#1175) - Ignore Leapp related PES events (oamg#1153) - Introduce generic transition of systemd services states during the IPU (oamg#1060, oamg#1174) - Introduce possibility to upgrade with local repositories (oamg#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (oamg#1140) - Report the upgrade customisations and modifications of the upgrade tooling (oamg#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (oamg#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (oamg#1163, oamg#1165, oamg#1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (oamg#1137, oamg#1165, oamg#1172) - Unify breakpoints inside the upgrade initramfs for the easier troubleshooting (oamg#1157) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (oamg#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (oamg#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (oamg#876)

## Packaging - Requires xfsprogs and e2fsprogs (#1154) - Bump leapp-repository-dependencies to 10 (#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (#1120) - Drop the invalid `tuv` target channel (#1130) - Fix handling of symlinks under /etc/pki when managing certificates (#1135, #1160, #1166) - Fix semanage import issue (#1164) - Fix the issue of going out of bounds in the isccfg parser (#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (#1134) - Minor updates of generated reports (#1151) - Print nice error msg when device and driver deprecation data is malformed (#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (#1136, #1138) ### Enhancements - Update upgrade paths: (#1146, #1147, #1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (#1143) - Code cleaning: drop redundant and invalid NFS checks (#1127) - Default to NO_RHSM mode when subscription-manager is not found (#1133) - Detect customized configuration of dynamic linker (#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (#1175) - Ignore Leapp related PES events (#1153) - Introduce generic transition of systemd services states during the IPU (#1060, #1174) - Introduce possibility to upgrade with local repositories (#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (#1140) - Report the upgrade customisations and modifications of the upgrade tooling (#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (#1163, #1165, #1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (#1137, #1165, #1172) - Unify breakpoints inside the upgrade initramfs for the easier troubleshooting (#1157) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (#876)

pirat89 self-requested a review January 22, 2024 15:45

pirat89 added the bug Something isn't working label Jan 22, 2024

pirat89 added this to the 8.10/9.4 milestone Jan 22, 2024

abadger force-pushed the fix-symlink-to-interior-directory branch from 5eb788f to 41321a1 Compare January 22, 2024 16:41

pirat89 approved these changes Jan 22, 2024

View reviewed changes

abadger mentioned this pull request Jan 22, 2024

Fix symlink to same exterior location #1167

Open

pirat89 merged commit bec6615 into oamg:master Jan 22, 2024
28 of 44 checks passed

pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jan 22, 2024

abadger deleted the fix-symlink-to-interior-directory branch January 24, 2024 16:39

pirat89 mentioned this pull request Feb 13, 2024

Release 0.20.0 #1177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix another cornercase with symlink handling #1166

Fix another cornercase with symlink handling #1166

abadger commented Jan 22, 2024 •

edited

github-actions bot commented Jan 22, 2024

pirat89 commented Jan 22, 2024 •

edited

pirat89 commented Jan 22, 2024 •

edited

abadger commented Jan 22, 2024

abadger commented Jan 22, 2024

pirat89 left a comment

Fix another cornercase with symlink handling #1166

Fix another cornercase with symlink handling #1166

Conversation

abadger commented Jan 22, 2024 • edited

github-actions bot commented Jan 22, 2024

Thank you for contributing to the Leapp project!

pirat89 commented Jan 22, 2024 • edited

Better view of the results + another outputs when needed (for both commits):

pirat89 commented Jan 22, 2024 • edited

abadger commented Jan 22, 2024

abadger commented Jan 22, 2024

pirat89 left a comment

Choose a reason for hiding this comment

abadger commented Jan 22, 2024 •

edited

pirat89 commented Jan 22, 2024 •

edited

pirat89 commented Jan 22, 2024 •

edited