Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] [WIP] IPU 9 -> 10: Initial preparation: upgrade paths and leapp packages def #1169

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Jan 23, 2024

Introducing initial changes needed for IPU 9 -> 10 to prevent abouvious crashes and inhibitors:

  • extend the list of supported source versions for the upgrade by el9
  • define upgrade paths for IPU 9 -> 10
  • define packages for RHEL 9 to prevent instant crashing of get_leapp_packages and get_leapp_dep_packages
    • note this could be still changed as the list of packages we will want in el 10 is not defined yet

TODO (required bare minimum changes for the IPU 9 -> 10):

  • add RHEL 10 product certificates
  • add RHEL 10 GPG keys
  • update unit-tests
  • packaging
  • Update Makefile (just partial changes now)
  • Update packit (just partially prepared)

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

},
LeappComponents.COCKPIT: {'7': {'pkgs': ['cockpit-leapp']},
'8': {'pkgs': ['cockpit-leapp']}
'8': {'pkgs': ['cockpit-leapp']},
'9': {'pkgs': ['']}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why [''] and not an empty list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, empty list is definitely expected. no idea why I put empty string inside /o\

"7": ["8.6", "8.8", "8.9", "8.10"],
"8": ["9.0", "9.2", "9.3", "9.4"]
"8": ["9.0", "9.2", "9.3", "9.4"],
"9": ["10.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say for each new upgrade path we should add a packit test. And ideally this should be done in this commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. Q is whether it will need some additional tweaks regarding major upgrade path change (sometimes it could include some specific infra changes). we should check that later. but with minor update paths we should start doing that definitely in this way.

@pirat89
Copy link
Member Author

pirat89 commented Apr 2, 2024

/packit copr-build

@Rezney Rezney force-pushed the poc-ipu-9-10 branch 2 times, most recently from 9c512d4 to 1e42b2b Compare April 12, 2024 21:41
Introducing initial changes needed for IPU 9 -> 10 to prevent abouvious
crashes and inhibitors:
* extend the list of supported source versions for the upgrade by el9
* define upgrade paths for IPU 9 -> 10

TODO:
* add RHEL 10 product certificates
* add RHEL 10 GPG keys

* Introducing el9toel10 repository
  created .gitkeep files inside empty dirs
TODO:
  - update commit msg
  - still incomplete - update Makefile

Partially updated Makefile
TODO:
* add certs for other architectures too
…ddrivers actor

Currently we do not have yet data here for RHEL 10 HW, so dropping the
actor for now. This cannot commit must be removed BEFORE the merge
in upstream.
…kages def

Enable upgrade from RHEL 9.4 & 9.5 to RHEL 10.0 for now. For the
experiment purposes. These will not be supported for the upgrade at all,
but to make testing and experimentations easier, allow it for now.
* TODO: this is just experimental, copied value from IPU 8 -> 9 to
  pass the execution without traceback. Check what should be really
  set inside.
Temporarily disabled, not sure now why. The commit will be for
sure changed or dropped before the merge.
Rezney and others added 2 commits April 22, 2024 12:01
The tool file is fine but we need to create a separate actor for this
Set common python deps + builds-deps for RHEL 8+. Previosly, build
deps have been set just for RHEL 8, not for RHEL 9, so we could not
create *pyc files for RHEL 9 builds due to missing macros.
Until RHELBLD-15138 is resolved
They are not owned by any package and can dynamically grow to
a huge amount of files causing hitting open files limit
"util-linux" package is not brought in as a dependency anymore and
we are missing "/usr/bin/su"
@Rezney
Copy link
Member

Rezney commented Jun 11, 2024

/packit copr-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants