Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2/parameter events #47

Merged
merged 6 commits into from
May 3, 2013
Merged

V2/parameter events #47

merged 6 commits into from
May 3, 2013

Conversation

kn0ll
Copy link

@kn0ll kn0ll commented Apr 7, 2013

this is a patch that provides interfaces for listening to parameter changes.

it relies on #43 which is not merged into version-2 yet which makes this commit log kind of messy.

the relevant commits are:

  1. Adding EventEmitter and emitting parameter changes on AudioletNodes and AudioletParameters
  2. adding parameter event example

the example and comments should hopefully explain the commit sufficiently.

@oampo
Copy link
Owner

oampo commented Apr 8, 2013

Yep, this looks good to me. Will you be able to clean up the commit trail when we merge #43? If so I'll wait to merge, otherwise I'll merge it now. There are a few other things which should probably happen when this is in which I've opened issues for - see #48 and #49.

@kn0ll
Copy link
Author

kn0ll commented Apr 8, 2013

the commits i think are fine, it's just the way GitHub displays the diff. so i think merging #43 might automatically clean up this diff. so i say we merge that first. if i'm wrong we can merge #43 first anyway and i'll clean it up manually. #48 and #49 are solid.

@kn0ll
Copy link
Author

kn0ll commented Apr 27, 2013

merging in parameter-map changes which i hope are solidified.

to reiterate, i suspect the commit log here will get cleaned up automatically once parameter-map is merged, but if not, i will either rewrite this pulls history or create a new one.

@kn0ll kn0ll mentioned this pull request Apr 27, 2013
oampo added a commit that referenced this pull request May 3, 2013
@oampo oampo merged commit 6cb2fea into oampo:version-2 May 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants