-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow performance with very long lines #39
Comments
One good test to try would be to test I wasn't fully aware of my motivation at the time, but in my personal configuration the expensive styles like initialism and flex are always introduced by explicit syntax. It must have been that I felt those were slower (but I never deal with long lines, so the difference is pretty small). |
I am not using flex by default since it seems so much more expensive. It always leads to a noticeable slowdown. But initialism is activated always. I am using the default settings with the explicit syntax for flex~ and literal= and !negated literal. |
My syntax for flex even has two characters! Again, probably subconsciously I felt it was even slower than initialism. I use a single (either leading or trailing) |
It is not unreasonable to use multiple characters for the explicit styles in order to avoid interference with regexps. And usually when I do an explicit style switching, typing two letters wouldn't make a difference. |
Just stumbled over this: https://github.com/doyensec/regexploit 😆 |
What about removing initialism from orderless by default? Instead recommend creating special orderless-styles which include more matching styles? And in any case we have the matching style dispatchers. (orderless-define-completion-style orderless+initialism
(orderless-matching-styles '(orderless-initialism orderless-literal orderless-regexp)))
(setq orderless-matching-styles '(orderless-literal orderless-regexp))
(setq completion-category-overrides
'((file (styles partial-completion orderless+initialism))
(command (styles orderless+initialism))
(buffer (styles orderless+initialism))
(consult-multi (styles orderless+initialism))
(symbol (styles orderless+initialism)))) |
To keep in mind, see radian-software/selectrum#436 (comment). Maybe nothing can be done for certain patterns which may necessarily result in high complexity. Needs further investigation.
The text was updated successfully, but these errors were encountered: