module: add :completion vertico #4664

edmundmiller · 2021-02-16T23:12:27Z

This is a work in progress, to quote the great @mjlbach "be the PR you want to see in the repo".

The only thing I take credit for so far is pinning the packages and copying and pasting @Townk's config ontop of @jethrokuan's PR (#4519) so I'll only take it personally if you rip up the way I pinned the repos.

Please add anything that you find isn't working to TODO.org or PR the fix.

This PR used to be named Add Selectrum Round 2

modules/completion/selectrum/config.el

bdarcus · 2021-02-17T15:40:24Z

I'm a newbie on this ecosystem of packages, but would consult-ripgrep be useful somewhere here?

edmundmiller · 2021-02-17T16:06:58Z

I'm a newbie on this ecosystem of packages, but would consult-ripgrep be useful somewhere here?

I think that's what +selectrum-file-search is aiming to replace.

bdarcus · 2021-02-17T19:23:18Z

I think that's what +selectrum-file-search is aiming to replace.

OIC; thanks.

modules/completion/selectrum/TODO.org

modules/config/default/+evil-bindings.el

edmundmiller · 2021-02-19T15:59:25Z

Could you drop a screenshot of the difference? Should just be (setq embark-collect-initial-view-alist ...) away, but what values are you using?

modules/completion/selectrum/autoload/selectrum.el

modules/completion/selectrum/config.el

minad · 2021-02-21T10:33:57Z

When grepping the doom-emacs codebase for ivy-read there seem to be a few other places where a completing-read implementation is missing and there are also a few TODO marks.

modules/completion/selectrum/config.el

edmundmiller · 2021-02-21T20:42:20Z

@minad I appreciate the review! Few questions on either and I'd love any further input you have.

modules/completion/selectrum/config.el

jethrokuan · 2021-02-23T05:13:28Z

Why is +selectrum-file-search reverted to consult-ripgrep? Wouldn't it then fail to handle +fuzzy, and also searching the correct directory?

bdarcus · 2021-02-23T14:30:14Z

I've run into a keybinding problem, explained here:

tmalsburg/helm-bibtex#355 (comment)

To summarize:

If one runs embark-act via the C-o keybinding defined here from selectrum, it works; it correctly invokes the command.

But if one from there runs embark-collect-snapshot (S) and go to that embark collect buffer, the same keybinding doesn't work in that context. You have to do M-x embark-act to access the command.

The embark author has this suggestion here.

You should bind some key to run embark-act in the Evil normal state in buffers that are in embark-collect-mode.

FWIW, by default, embark has that bound to a in that case, but it's also accessible via the default binding for embark-act.

bdarcus · 2021-02-23T16:06:25Z

Why is +selectrum-file-search reverted to consult-ripgrep? Wouldn't it then fail to handle +fuzzy, and also searching the correct directory?

See the sub-thread above @jethrokuan:

#4664 (comment)

It's just temporary.

edmundmiller · 2021-02-24T04:18:57Z

Why is +selectrum-file-search reverted to consult-ripgrep? Wouldn't it then fail to handle +fuzzy, and also searching the correct directory?

I couldn't get your version to work locally the first time I tried it, so I was using a combination of pieces that others had written, but kept not getting anywhere, so I took @minad's advice and cut it down. Anyways, I gave yours another go to confirm, and it appears to be working now.

jethrokuan · 2021-02-24T05:47:49Z

I didn't really know what I was doing wrt to the this-command override either, but it was working for me then 🤷 . Maybe it's safe to remove that clause.

modules/completion/selectrum/autoload/selectrum.el

- Use `vertico` as default completion engine - Drop `selectrum` and `selectrum-prescient` support

- Rename module from `:completion selectrum` to `:completion vertico` - Rename all files involved - Do *not* yet rename all the functions, as that messes up git's rename detection.

- Rename all functions and variables in the module to reflect the namechange (and the irc jump function)

- Add basic configuration instructions - Add Vertico keybindings - Improve =C-c C-e= documentation - Prepare TODO for PR review

It didn't do anything for the `orderless` statement, and we can setup `embark-consult` correctly without it.

motion preview commands to underlying motion commands.

minad/vertico@9f6cd5d -> minad/vertico@e1faeb0 minad/consult@f17db95 -> minad/consult@5fb6248 oantolin/embark@acbe1cb -> oantolin/embark@9d56be1 minad/marginalia@3bf0a4d -> minad/marginalia@d4c2028 iyefrat/all-the-icons-completion@975345f -> iyefrat/all-the-icons-completion@24cdb3b

cleans up shadowed paths automatically

While it only gives one candidate per line, it's more important to have something that uses the completion UI

- unify `map!` statements when possible - rename `+vertico--embark-target-package!` to `+vertico--embark-target-package` and autoload it - set `completion-in-region-function` to a wrapper function instead of changing it with a hook - use `:override` advice instead of `fset` for `multi-occur` - document what `vertico-directory-tidy` does - move `:init` contents to `:config` when possible

minad/consult@5fb6248 -> minad/consult@28f9ba8 minad/marginalia@d4c2028 -> minad/marginalia@a3a8edb minad/vertico@e1faeb0 -> minad/vertico@4a90297 oantolin/embark@9d56be1 -> oantolin/embark@be03ce9 oantolin/orderless@2646dad -> oantolin/orderless@1e84120

emacs-citar/citar@b1ddbb3 -> emacs-citar/citar@6e3a194 tmalsburg/helm-bibtex@9f6ea92 -> tmalsburg/helm-bibtex@a0d32ab tmalsburg/helm-bibtex@9f6ea92 -> tmalsburg/helm-bibtex@a0d32ab tmalsburg/helm-bibtex@9f6ea92 -> tmalsburg/helm-bibtex@a0d32ab bibtex-actions is way out of date, and bibtex-completion has a new org-cite improvement

d12frosted/flyspell-correct@4042336 -> d12frosted/flyspell-correct@0035795 flyspell-correct got some completing-read improvements relevant to completion/vertico

@iyefrat

- move TODO.org to discourse (https://discourse.doomemacs.org/t/vertico-module-tasklist/1386) - update README date - add @iyefrat as maintainer

modules/config/default/+evil-bindings.el

+      (:when (featurep! :completion vertico)
+        (:after vertico
+         :map vertico-map
+         "M-RET" #'vertico-exit-input


hlissner · 2021-07-25T08:12:52Z

And bam! Thanks for all your help guys, especially @iyefrat. Looking forward to giving this a spin!

iyefrat · 2021-07-25T08:18:43Z

I would also like to say thanks to all the people that worked on, reviewed, and beta tested the module. Particularly to @minad, but the full list is too long for me to write out without forgetting someone by accident.

ttys3 · 2021-07-26T05:31:58Z

Finally, this get merged! Cheers

Refs: doomemacs/doomemacs#4664

ymarco reviewed Feb 16, 2021

View reviewed changes

modules/completion/selectrum/config.el Outdated Show resolved Hide resolved

bdarcus reviewed Feb 17, 2021

View reviewed changes

modules/completion/selectrum/TODO.org Outdated Show resolved Hide resolved

bdarcus mentioned this pull request Feb 18, 2021

add selectrum module #4519

Closed

bdarcus reviewed Feb 19, 2021

View reviewed changes

modules/completion/selectrum/TODO.org Outdated Show resolved Hide resolved

bdarcus reviewed Feb 19, 2021

View reviewed changes

modules/config/default/+evil-bindings.el Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

minad reviewed Feb 21, 2021

View reviewed changes

modules/completion/selectrum/autoload/selectrum.el Outdated Show resolved Hide resolved

minad reviewed Feb 21, 2021

View reviewed changes

modules/completion/selectrum/config.el Outdated Show resolved Hide resolved

minad reviewed Feb 21, 2021

View reviewed changes

modules/completion/selectrum/config.el Outdated Show resolved Hide resolved

bdarcus reviewed Feb 21, 2021

View reviewed changes

modules/completion/selectrum/config.el Outdated Show resolved Hide resolved

minad mentioned this pull request Feb 21, 2021

Drop Emacs 25 support? radian-software/selectrum#454

Closed

bdarcus reviewed Feb 22, 2021

View reviewed changes

modules/completion/selectrum/config.el Outdated Show resolved Hide resolved

bdarcus mentioned this pull request Feb 23, 2021

[WIP] Add embark-bibtex frontend. tmalsburg/helm-bibtex#355

Open

edmundmiller mentioned this pull request Feb 24, 2021

Low contrast with doom-nord-light and marginalia/selectrum doomemacs/themes#573

Closed

minad reviewed Feb 24, 2021

View reviewed changes

modules/completion/selectrum/autoload/selectrum.el Outdated Show resolved Hide resolved

edmundmiller force-pushed the selectrum branch from b665880 to 9852950 Compare February 24, 2021 15:34

This comment has been minimized.

Sign in to view

iyefrat added 18 commits July 25, 2021 02:50

completion/selectrum -> completion/vertico, part 1

f9e1c99

- Use `vertico` as default completion engine - Drop `selectrum` and `selectrum-prescient` support

completion/selectrum -> completion/vertico, part 2

24eaa13

- Rename module from `:completion selectrum` to `:completion vertico` - Rename all files involved - Do *not* yet rename all the functions, as that messes up git's rename detection.

completion/selectrum -> completion/vertico, part 3

a0eb4e9

- Rename all functions and variables in the module to reflect the namechange (and the irc jump function)

vertico: Improve README and update TODO...

34f8e1f

- Add basic configuration instructions - Add Vertico keybindings - Improve =C-c C-e= documentation - Prepare TODO for PR review

vertico: remove :demand t from use-package's

41e657f

It didn't do anything for the `orderless` statement, and we can setup `embark-consult` correctly without it.

vertico: pass universal argument from vertico...

f8a64c8

motion preview commands to underlying motion commands.

vertico: add consult buffer source for org buffers

099f851

vertico: use all-the-icons-completion-marginalia-setup

d0f4c5f

vertico: use vertico-directory-tidy

29bd530

cleans up shadowed paths automatically

vertico: use consult-line in +default/search-buffer

770084f

While it only gives one candidate per line, it's more important to have something that uses the completion UI

vertico: defer loading of embark and orderless

c12fb64

vertico: fix unused lexical variable error

a4093e9

Bump :checkers spell

aff25b1

d12frosted/flyspell-correct@4042336 -> d12frosted/flyspell-correct@0035795 flyspell-correct got some completing-read improvements relevant to completion/vertico

vertico: add variable to set company completion styles

e2cd827

iyefrat force-pushed the selectrum branch from fd5e3e7 to 415ad7f Compare July 24, 2021 23:54

vertico: prepare for merge...

beb0b44

- move TODO.org to discourse (https://discourse.doomemacs.org/t/vertico-module-tasklist/1386) - update README date - add @iyefrat as maintainer

iyefrat force-pushed the selectrum branch from 415ad7f to beb0b44 Compare July 24, 2021 23:58

daanturo reviewed Jul 25, 2021

View reviewed changes

modules/config/default/+evil-bindings.el

(:when (featurep! :completion vertico)

(:after vertico

:map vertico-map

"M-RET" #'vertico-exit-input

This comment was marked as outdated.

Sign in to view

hlissner merged commit 10a42a9 into doomemacs:develop Jul 25, 2021

ttys3 added a commit to ttys3/.doom.d that referenced this pull request Jul 26, 2021

refactor: use vertico instead of ivy

f177ffe

Refs: doomemacs/doomemacs#4664

github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2021

hlissner changed the title ~~Add Vertico module~~ module: add :completion vertico Aug 3, 2022

hlissner added the module:completion/vertico Pertains to Doom's :completion vertico module label Aug 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module: add :completion vertico #4664

module: add :completion vertico #4664

edmundmiller commented Feb 16, 2021 •

edited

bdarcus commented Feb 17, 2021

edmundmiller commented Feb 17, 2021

bdarcus commented Feb 17, 2021 •

edited

This comment has been minimized.

edmundmiller commented Feb 19, 2021

This comment has been minimized.

This comment has been minimized.

minad commented Feb 21, 2021

edmundmiller commented Feb 21, 2021

jethrokuan commented Feb 23, 2021

bdarcus commented Feb 23, 2021 •

edited

bdarcus commented Feb 23, 2021

edmundmiller commented Feb 24, 2021

jethrokuan commented Feb 24, 2021

This comment has been minimized.

This comment was marked as outdated.

hlissner commented Jul 25, 2021

iyefrat commented Jul 25, 2021

ttys3 commented Jul 26, 2021

module: add :completion vertico #4664

module: add :completion vertico #4664

Conversation

edmundmiller commented Feb 16, 2021 • edited

bdarcus commented Feb 17, 2021

edmundmiller commented Feb 17, 2021

bdarcus commented Feb 17, 2021 • edited

This comment has been minimized.

edmundmiller commented Feb 19, 2021

This comment has been minimized.

This comment has been minimized.

minad commented Feb 21, 2021

edmundmiller commented Feb 21, 2021

jethrokuan commented Feb 23, 2021

bdarcus commented Feb 23, 2021 • edited

bdarcus commented Feb 23, 2021

edmundmiller commented Feb 24, 2021

jethrokuan commented Feb 24, 2021

This comment has been minimized.

This comment was marked as outdated.

hlissner commented Jul 25, 2021

iyefrat commented Jul 25, 2021

ttys3 commented Jul 26, 2021

edmundmiller commented Feb 16, 2021 •

edited

bdarcus commented Feb 17, 2021 •

edited

bdarcus commented Feb 23, 2021 •

edited