Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-660] fix window builder with string #649

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Dec 22, 2021

What changes were proposed in this pull request?

fix window output with string array
Signed-off-by: Yuan Zhou yuan.zhou@intel.com

How was this patch tested?

pass jenkins

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@zhouyuan zhouyuan changed the title [DNM] fix window agg over string [DNM] fix window builder with string Dec 22, 2021
@zhouyuan zhouyuan changed the title [DNM] fix window builder with string [NSE-660] fix window builder with string Dec 24, 2021
@github-actions
Copy link

#660

@zhouyuan zhouyuan merged commit 9f9f10d into oap-project:master Dec 24, 2021
zhouyuan added a commit that referenced this pull request Dec 30, 2021
* [NSE-636]Remove log4j1 related unit tests (#646)

* [NSE-640] Disable compression for tiny payloads in shuffle (#641)

Closes #640

* [NSE-653] Add validity checking for get_json_object in WSCG (#654)

* Initial commit

* Add two unit test cases

* Format the code

* Update clang format check

* [NSE-617] Handle exception in cast expression from string to numeric types in WSCG (#655)

* [NSE-660] fix window builder with string (#649)

* fix window builder with string

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-650] Scala test ArrowColumnarBatchSerializerSuite is failing  (#659)

Closes #650

* [NSE-645] Add support to cast bool type to bigint type & string type (#644)

* Initial commit

* Change arrow branch for test [revert this commit at last]

* Revert "Change arrow branch for test [revert this commit at last]"

This reverts commit 94ce7fbfc4025d48c252f91701459b4ed091dad9.

* use arrow 1.3 branch

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-662] Add "like" expression support in WSCG (#663)

* Initial commit

* Copy headers

* Format the code

* Change arrow branch for test [will revert at last]

* Revert "Change arrow branch for test [will revert at last]"

This reverts commit 065547a.

* [NSE-126] remove extra headers/namespaces in codegen (#668)

* remove extra gandiva header

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* remove extra using namespace

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-661] Add trim expression support in WSCG (#664)

* Add trim expression support in WSCG

* Fix a bug

* Format the code

Co-authored-by: Wei-Ting Chen <weiting.chen@intel.com>
Co-authored-by: Hongze Zhang <hongze.zhang@intel.com>
Co-authored-by: PHILO-HE <feilong.he@intel.com>
@weiting-chen weiting-chen added this to Done in Release 1.3.0 Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant