Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velox does not install folly in centos8 by default, break compile in centos8. #772

Closed
Yohahaha opened this issue Dec 28, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working velox backend works for Velox backend

Comments

@Yohahaha
Copy link
Contributor

Describe the bug
Velox remove install folly in centos 4f528, when compile gluten, find_package(folly) will throw error.

To Reproduce
./tools/one_step_veloxbackend.sh or separate build velox then build gluten can reproduce.

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Velox still install folly in setup_ubuntu.
So, if i execute cd /path-to-gluten/ep/build-velox/build/velox_ep/_build/release/_deps/ & cmake --install folly-build, everything would be ok.

What's community's options about this? I could submit a PR if needed.

@Yohahaha Yohahaha added the bug Something isn't working label Dec 28, 2022
@jinchengchenghh
Copy link
Contributor

How about using resolve_dependency macro as velox does in 4f528? @FelixYBW

@Fiooodooor
Copy link

This just should be added to the centos8 deployment

(
  git clone https://github.com/facebook/folly &&
  cd folly &&
  git checkout $FB_OS_VERSION &&
  cmake_install -DBUILD_TESTS=OFF -DBUILD_SHARED_LIBS=ON
)

@FelixYBW
Copy link
Contributor

FelixYBW commented Mar 8, 2023

@zhejiangxiaomai

@zhejiangxiaomai
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working velox backend works for Velox backend
Projects
None yet
Development

No branches or pull requests

7 participants