[GLUTEN-1199] Avoid throwing exception from destructor of JavaInputStreamAdaptor #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for catching this! |
jinchengchenghh
previously approved these changes
Apr 26, 2023
zhztheplayer
changed the title
zhztheplayer
changed the title
zhztheplayer
changed the title
zhztheplayer
changed the title
zhztheplayer
previously approved these changes
Apr 26, 2023
cambyzju
dismissed stale reviews from zhztheplayer and jinchengchenghh
via
71a8e91
cambyzju
force-pushed
the
fix-terminate-by-exception
branch
from
a9b9a76
to
71a8e91
Compare
done |
This pr do not relate to memory leak issue. I will try to found it out and fix it next week. |
|
@zhztheplayer This pr is related to #1187 and it is a better fix to deal with |
zhztheplayer
changed the title
|
Will merge the patch soon, if there is no more comment. |
PHILO-HE
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HINT: Throw an exception in destructor is dangerous and you should never let the exception leave destructors. If there are two exceptions propagating, the program will terminate or yield undefined behavior.inside function Java_io_glutenproject_vectorized_ShuffleReaderJniWrapper_make
But between step2 and step3, destructor of JavaInputStreamAdaptor is called, then we got another exception, the process terminate.
(Fixes: #1199)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)