current user refresh #115
Merged
current user refresh #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesemus
force-pushed
the
alzbetapokorna/be-193-fix-current_user-not-in-sync-on-first-build
branch
from
47fa116
to
046cf15
Compare
mesemus
requested changes
Dec 16, 2023
| def __init__(self): | ||
| super().__init__() | ||
| self.jinja_env.undefined = jinja2.Undefined | ||
| def __init__( |
There was a problem hiding this comment.
Do we have to overwrite the constructor? It seems that the only line modified is 51 and that is done to pass the current_app.
The app is used on 101:
if name in self.jinja_env.app.template_context_processors
can it be changed to if name in current_app.template_context_processors ?
Also, we need tests for this functionality (register test blueprint with context processor and make sure it gets called)
…irst-build' of https://github.com/oarepo/oarepo-ui into alzbetapokorna/be-193-fix-current_user-not-in-sync-on-first-build
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…tapokorna/be-193-fix-current_user-not-in-sync-on-first-build
|
mesemus
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.