Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import components from top level modules #72

Open
mirekys opened this issue Jul 20, 2023 · 0 comments
Open

Import components from top level modules #72

mirekys opened this issue Jul 20, 2023 · 0 comments
Labels
enhancement New feature or request frontend performance

Comments

@mirekys
Copy link
Member

mirekys commented Jul 20, 2023

This is required for Vite prebundling to work effectively.
We should strive to import stuff from top level modules where possible.

Bad:

import { MultipleOptionsSearchBar } from "@js/oarepo_ui/components";

Better:

import { MultipleOptionsSearchBar } from "@js/oarepo_ui";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request frontend performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mirekys