fix: report schema errors #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the action fails silently when there's an errors in the OpenAPI spec.
tuxmachine
force-pushed
the
fix/report-schema-errors
branch
from
8126476
to
f778148
Compare
effoeffi
reviewed
Feb 1, 2024
There was a problem hiding this comment.
I believe we should include a call to oasdiff in the changelog and diff, similar to what we're currently doing in the breaking action. This approach would enhance uniformity and consistency. Additionally, we could eliminate the need for 2>&1 and set -/+e and the error check at the end.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the action fails silently when there's an errors in the OpenAPI spec.
I've tested this on our own fork that uses a tweaked version of the
breakingaction, but it should probably be tested a bit further by people that use the other actions.