Can't add custom observables to Observed Data object

[clenk]

No description provided.

[AdamTheAnalyst]

+1 to this issue - We are doing this by dumping to JSON, adding our properties in, and re-wrapping as ObservedData

[AdamTheAnalyst]

Just to add to this - you currently cant have a custom observable in ObservedData - working on a patch:

InvalidValueError: Invalid value for ObservedData 'objects': Can't parse unknown object type 'x-location'! For custom observables, use the CustomObservable decorator.

[AdamTheAnalyst]

Example bug code

#!/usr/bin/python
import json
import stix2
from datetime import datetime
from stix2 import ObservedData

@stix2.observables.CustomObservable(type='x-location', properties={
    'country': stix2.properties.StringProperty(required=True),
    'city': stix2.properties.StringProperty(),
})
class CustomLocation():
        def __init__(self, **kwargs):
                pass

location = CustomLocation(country="England",city="Birmingham")

obsd = ObservedData(first_observed=datetime.now(),last_observed=datetime.now(), number_observed=1,objects={
                                        "0":json.loads(str(location))
                                        },allow_custom=True)

[clenk]

Thank you for the feedback, @AdamTheAnalyst! I've renamed this issue since the bug you found is unrelated to the original issue, and made a new issue for the original feature this one was referring to.

I'm also looking into your error and adding a unit test for it.