Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp code related to "pretty" JSON serialization #192

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

chisholm
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #192 into master will decrease coverage by 0.04%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   99.54%   99.49%   -0.05%     
==========================================
  Files          62       62              
  Lines        6538     6520      -18     
==========================================
- Hits         6508     6487      -21     
- Misses         30       33       +3
Impacted Files Coverage Δ
stix2/base.py 99.47% <100%> (-0.01%) ⬇️
stix2/test/test_utils.py 100% <100%> (ø) ⬆️
stix2/utils.py 98.2% <96.15%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee059b0...f09960d. Read the comment docs.

@gtback gtback requested a review from emmanvg June 15, 2018 13:23
@gtback gtback added this to the 1.0.2 milestone Jun 15, 2018
Copy link
Contributor

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It seems more elegant (fewer levels of nesting). I'm a bit concerned by the drop in coverage, but as long as the tests are still passing, I'm pretty sure the effective behavior hasn't changed.

@gtback
Copy link
Contributor

gtback commented Jun 15, 2018

@emmanvg can you look at this and provide any feedback, too?

@emmanvg
Copy link
Contributor

emmanvg commented Jun 15, 2018

I am ok with the approach. There shouldn't be any more comparison error being raised. Though, when a property is not found the object will simply be printed out of order.

@gtback gtback merged commit 2ec5ba4 into oasis-open:master Jun 15, 2018
@chisholm chisholm deleted the serialize_fix branch June 15, 2018 20:13
@gtback gtback modified the milestones: 1.0.2, 1.0.3 Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants