Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "contains" filter #203

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Add "contains" filter #203

merged 1 commit into from
Jul 5, 2018

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Jul 2, 2018

This allows filtering on, for example, observed-data objects that contain a specific cyber observable.

Related: #200.

This allows filtering on, for example, observed-data objects that
contain a specific cyber observable.
@codecov-io
Copy link

Codecov Report

Merging #203 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage    99.5%   99.53%   +0.02%     
==========================================
  Files          62       62              
  Lines        6527     6731     +204     
==========================================
+ Hits         6495     6700     +205     
+ Misses         32       31       -1
Impacted Files Coverage Δ
stix2/test/test_datastore_filters.py 100% <100%> (ø) ⬆️
stix2/datastore/filters.py 98.05% <100%> (+0.07%) ⬆️
stix2/test/test_utils.py 100% <0%> (ø) ⬆️
stix2/test/test_observed_data.py 100% <0%> (ø) ⬆️
stix2/base.py 99.5% <0%> (+0.03%) ⬆️
stix2/utils.py 99.57% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5d35f...f47809e. Read the comment docs.

@gtback gtback self-assigned this Jul 5, 2018
@gtback gtback added this to the 1.0.3 milestone Jul 5, 2018
@gtback gtback self-requested a review July 5, 2018 20:41
Copy link
Contributor

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtback gtback merged commit 49c1931 into master Jul 5, 2018
@gtback gtback deleted the 200-filter-contains branch July 5, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants