Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocol_family from the v21 network socket SCO extension #427

Merged
merged 1 commit into from Jul 9, 2020
Merged

Remove protocol_family from the v21 network socket SCO extension #427

merged 1 commit into from Jul 9, 2020

Conversation

chisholm
Copy link
Contributor

@chisholm chisholm commented Jul 8, 2020

Fixes #426 .

@chisholm
Remove protocol_family and its uses from the v21 network
d888eb6 
socket SCO extension.  It's a 2.0 property that got copied into
the 2.1 code by mistake.
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020 •
edited

Codecov Report

Merging #427 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files         130      130              
  Lines       14887    14886       -1     
==========================================
- Hits        14645    14644       -1     
  Misses        242      242
Impacted Files Coverage Δ
stix2/test/v21/test_observed_data.py 100.00% <ø> (ø)
stix2/v21/observables.py 96.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f08ad0...d888eb6. Read the comment docs.

clenk
clenk approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@clenk clenk merged commit c497038 into oasis-open:master Jul 9, 2020
@emmanvg emmanvg added this to the 2.0.3 milestone Jul 9, 2020
@chisholm chisholm deleted the remove_v21_protocol_family branch July 22, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

2.1 network socket extension class has holdover 2.0 property: protocol_family
4 participants
@chisholm @codecov-commenter @clenk @emmanvg