Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle mixed boolean expressions #436

Merged
merged 1 commit into from Jul 24, 2020
Merged

handle mixed boolean expressions #436

merged 1 commit into from Jul 24, 2020

Conversation

rpiazza
Copy link
Contributor

@rpiazza rpiazza commented Jul 24, 2020 •
edited by clenk

Fixes #435.

@rpiazza rpiazza requested a review from chisholm July 24, 2020 15:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020 •
edited

Codecov Report

Merging #436 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   98.37%   98.38%   +0.01%     
==========================================
  Files         130      130              
  Lines       14892    14906      +14     
==========================================
+ Hits        14650    14666      +16     
+ Misses        242      240       -2
Impacted Files Coverage Δ
stix2/pattern_visitor.py 91.49% <100.00%> (+0.88%) ⬆️
stix2/test/v20/test_pattern_expressions.py 100.00% <100.00%> (ø)
stix2/test/v21/test_pattern_expressions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb82bee...084941d. Read the comment docs.

chisholm
chisholm approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@chisholm chisholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fixed! Thanks.

@clenk clenk merged commit bcd3eb3 into master Jul 24, 2020
@emmanvg emmanvg added this to the 2.1.0 milestone Jul 27, 2020
@emmanvg emmanvg deleted the issue_435 branch August 7, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

@chisholm chisholm chisholm approved these changes

Assignees

@clenk clenk

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Pattern AST creation bug
5 participants
@rpiazza @codecov-commenter @clenk @chisholm @emmanvg